[PATCH] http.c: Spell the null pointer as NULL

2013-10-24 Thread Ramsay Jones 

Commit 1bbcc224 (http: refactor options to http_get_*, 28-09-2013)
changed the type of final 'options' argument of the http_get_file()
function from an int to an 'struct http_get_options' pointer.
However, it neglected to update the (single) call site. Since this
call was passing '0' to that argument, it was (correctly) being
interpreted as a null pointer. Change to argument to NULL.

Noticed by sparse. (Using plain integer as NULL pointer)

Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---

Hi Junio,

This is a repost of:

  http://article.gmane.org/gmane.comp.version-control.git/236201

I suspect that this simply fell through the cracks ... (if not,
please let me know ;-)

ATB,
Ramsay Jones

 http.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/http.c b/http.c
index 96d7578..b133ffd 100644
--- a/http.c
+++ b/http.c
@@ -1045,7 +1045,7 @@ static char *fetch_pack_index(unsigned char *sha1, const 
char *base_url)
strbuf_addf(buf, %s.temp, sha1_pack_index_name(sha1));
tmp = strbuf_detach(buf, NULL);
 
-   if (http_get_file(url, tmp, 0) != HTTP_OK) {
+   if (http_get_file(url, tmp, NULL) != HTTP_OK) {
error(Unable to get pack index %s, url);
free(tmp);
tmp = NULL;
-- 
1.8.4
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] http.c: Spell the null pointer as NULL

2013-10-24 Thread Jonathan Nieder 
Ramsay Jones wrote:

 Commit 1bbcc224 (http: refactor options to http_get_*, 28-09-2013)
 changed the type of final 'options' argument of the http_get_file()
 function from an int to an 'struct http_get_options' pointer.
 However, it neglected to update the (single) call site. Since this
 call was passing '0' to that argument, it was (correctly) being
 interpreted as a null pointer. Change to argument to NULL.

Jeff King wrote:

 Thanks, patch is obviously correct (and the cause was just oversight on
 my part).

For what it's worth, against the jk/http-auth-redirects branch,

Reviewed-by: Jonathan Nieder jrnie...@gmail.com
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] http.c: Spell the null pointer as NULL

2013-10-24 Thread Junio C Hamano 
Thanks.
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] http.c: Spell the null pointer as NULL

2013-10-15 Thread Ramsay Jones 

Commit 1bbcc224 (http: refactor options to http_get_*, 28-09-2013)
changed the type of final 'options' argument of the http_get_file()
function from an int to an 'struct http_get_options' pointer.
However, it neglected to update the (single) call site. Since this
call was passing '0' to that argument, it was (correctly) being
interpreted as a null pointer. Change to argument to NULL.

Noticed by sparse. (Using plain integer as NULL pointer)

Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---

Hi Jonathan, Junio,

I'm a little puzzled by not having noticed this until this evening! ;-)
Also, I note that ma...@kernel.org != ma...@repo.or.cz/jrn

ATB,
Ramsay Jones

 http.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/http.c b/http.c
index 96d7578..b133ffd 100644
--- a/http.c
+++ b/http.c
@@ -1045,7 +1045,7 @@ static char *fetch_pack_index(unsigned char *sha1, const 
char *base_url)
strbuf_addf(buf, %s.temp, sha1_pack_index_name(sha1));
tmp = strbuf_detach(buf, NULL);
 
-   if (http_get_file(url, tmp, 0) != HTTP_OK) {
+   if (http_get_file(url, tmp, NULL) != HTTP_OK) {
error(Unable to get pack index %s, url);
free(tmp);
tmp = NULL;
-- 
1.8.4
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] http.c: Spell the null pointer as NULL

2013-10-15 Thread Jeff King 
On Tue, Oct 15, 2013 at 10:55:02PM +0100, Ramsay Jones wrote:

 Commit 1bbcc224 (http: refactor options to http_get_*, 28-09-2013)
 changed the type of final 'options' argument of the http_get_file()
 function from an int to an 'struct http_get_options' pointer.
 However, it neglected to update the (single) call site. Since this
 call was passing '0' to that argument, it was (correctly) being
 interpreted as a null pointer. Change to argument to NULL.

Thanks, patch is obviously correct (and the cause was just oversight on
my part).

-Peff
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] http.c: Spell the null pointer as NULL

2013-10-15 Thread Junio C Hamano 
Ramsay Jones ram...@ramsay1.demon.co.uk writes:

 Also, I note that ma...@kernel.org != ma...@repo.or.cz/jrn

Thanks.
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html