[PATCH] pack-bitmap: do not core dump

2014-04-22 Thread Kyle J. McKay
So I was trying to use pack.writebitmaps=true and all I got was core dumps. The fix with a real subject line ;) is below. I think perhaps this should be picked up for the 2.0.0 release. (Patch is against master.) --Kyle 8 Subject: [PATCH] ewah_bitmap.c: do not assume size_t and

Re: [PATCH] pack-bitmap: do not core dump

2014-04-22 Thread Junio C Hamano
Kyle J. McKay mack...@gmail.com writes: So I was trying to use pack.writebitmaps=true and all I got was core dumps. The fix with a real subject line ;) is below. I think perhaps this should be picked up for the 2.0.0 release. (Patch is against master.) Of course---a breakage in a new code

Re: [PATCH] pack-bitmap: do not core dump

2014-04-22 Thread Jeff King
On Tue, Apr 22, 2014 at 03:53:02PM -0700, Kyle J. McKay wrote: So I was trying to use pack.writebitmaps=true and all I got was core dumps. Eek. The fix with a real subject line ;) is below. I think perhaps this should be picked up for the 2.0.0 release. (Patch is against master.) Yes,

Re: [PATCH] pack-bitmap: do not core dump

2014-04-22 Thread Kyle J. McKay
On Apr 22, 2014, at 16:17, Jeff King wrote: but I do not think that is necessarily any more readable, especially because we probably need to cast it like: self-rlw = (eword_t *)((uint8_t *)self-buffer + rlw_offset); I suspect that will produce a warning about a cast increasing pointer