[PATCH] parseopt: do not translate empty help string

2012-08-20 Thread Thomas Rast
The gettext .po files have a header, but it looks like the translation specification for an empty string. This results in _() actually returning that header. Prevent parseopt from passing empty strings to gettext when it displays help about commands. In some instances it already did this, but

Re: [PATCH] parseopt: do not translate empty help string

2012-08-20 Thread Junio C Hamano
Thomas Rast tr...@student.ethz.ch writes: The gettext .po files have a header, but it looks like the translation specification for an empty string. This results in _() actually returning that header. Prevent parseopt from passing empty strings to gettext when it displays help about

Re: [PATCH] parseopt: do not translate empty help string

2012-08-20 Thread Thomas Rast
Junio C Hamano gits...@pobox.com writes: Thomas Rast tr...@student.ethz.ch writes: The gettext .po files have a header, but it looks like the translation specification for an empty string. This results in _() actually returning that header. Thanks; this is a tricky bit to catch and makes

Re: [PATCH] parseopt: do not translate empty help string

2012-08-20 Thread Junio C Hamano
Thomas Rast tr...@student.ethz.ch writes: Junio C Hamano gits...@pobox.com writes: Thomas Rast tr...@student.ethz.ch writes: The gettext .po files have a header, but it looks like the translation specification for an empty string. This results in _() actually returning that header.

Re: [PATCH] parseopt: do not translate empty help string

2012-08-20 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: Oh, I forgot that we actually had a wrapper instead of the usual _. Yes, I think that would be the better solution to guard against this. OK, then let's replace the patch text of your commit ;-). He, we need to update the log message a bit, too. -- 8

Re: [PATCH] parseopt: do not translate empty help string

2012-08-20 Thread Thomas Rast
Junio C Hamano gits...@pobox.com writes: Junio C Hamano gits...@pobox.com writes: Oh, I forgot that we actually had a wrapper instead of the usual _. Yes, I think that would be the better solution to guard against this. OK, then let's replace the patch text of your commit ;-). He, we need