Re: [PATCH] pull: Do not abuse 'break' inside a shell 'case'

2014-06-11 Thread Junio C Hamano
Jacek Konieczny writes: > It is not C. The code would break under mksh when 'pull.ff' is set: > > $ git pull > /usr/lib/git-core/git-pull[67]: break: can't break > Already up-to-date. > > Signed-off-by: Jacek Konieczny > --- Thanks for spotting; I cannot believe this somehow got through u

[PATCH] pull: Do not abuse 'break' inside a shell 'case'

2014-06-11 Thread Jacek Konieczny
It is not C. The code would break under mksh when 'pull.ff' is set: $ git pull /usr/lib/git-core/git-pull[67]: break: can't break Already up-to-date. Signed-off-by: Jacek Konieczny --- git-pull.sh | 2 -- 1 file changed, 2 deletions(-) diff --git a/git-pull.sh b/git-pull.sh index 6cd8ebc