Alex Henrie writes:
> I pushed to change [options] to [] because even if the angle
> brackets don't help new users or translators in this particular case,
> the angle brackets encourage Git authors to use angle brackets when
> writing commands that are not so easy to
2015-10-19 23:17 GMT-06:00 Junio C Hamano :
> Alex Henrie writes:
>
>> 2015-10-16 11:42 GMT-06:00 Junio C Hamano :
>>>
>>> Yes, but that fixes historical "mistake", no?
>>>
>>> With this, you are breaking historical practice by
2015-10-16 11:42 GMT-06:00 Junio C Hamano :
> Alex Henrie writes:
>
>> 2015-10-16 10:36 GMT-06:00 Junio C Hamano :
>>> Makes sense, as all the other in the usage string are
>>> bracketted.
>>>
>>> Does it make sense to do this for
Alex Henrie writes:
> 2015-10-16 11:42 GMT-06:00 Junio C Hamano :
>>
>> Yes, but that fixes historical "mistake", no?
>>
>> With this, you are breaking historical practice by changing only one
>> instance to deviate from the then-current practice of
Alex Henrie wrote:
> ---
> builtin/pull.c | 2 +-
> contrib/examples/git-pull.sh | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/builtin/pull.c b/builtin/pull.c
> index a39bb0a..bf3fd3f 100644
> --- a/builtin/pull.c
> +++
Alex Henrie writes:
> 2015-10-16 10:36 GMT-06:00 Junio C Hamano :
>> Makes sense, as all the other in the usage string are
>> bracketted.
>>
>> Does it make sense to do this for contrib/examples, which is the
>> historical record, though?
>
> I didn't
Ralf Thielow writes:
> There seem to be three more places left missing these angle brances
> at the usage string.
> Junio, feel free to squash this or treat it as a separate patch
> on top, if suitable.
Thanks. Will queue.
>
> -- >8 --
> From: Ralf Thielow
Alex Henrie writes:
> Signed-off-by: Alex Henrie
> ---
Makes sense, as all the other in the usage string are
bracketted.
Does it make sense to do this for contrib/examples, which is the
historical record, though? The first one I found with
2015-10-16 10:36 GMT-06:00 Junio C Hamano :
> Makes sense, as all the other in the usage string are
> bracketted.
>
> Does it make sense to do this for contrib/examples, which is the
> historical record, though?
I didn't know that contrib/examples was a historical record. The
Signed-off-by: Alex Henrie
---
builtin/pull.c | 2 +-
contrib/examples/git-pull.sh | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/builtin/pull.c b/builtin/pull.c
index a39bb0a..bf3fd3f 100644
--- a/builtin/pull.c
+++ b/builtin/pull.c
10 matches
Mail list logo