Re: [PATCH] remote-hg: fix commit messages

2013-04-18 Thread Junio C Hamano
Felipe Contreras writes: > git fast-import expects an extra newline after the commit message data, > but we are adding it only on hg-git compat mode, which is why the > bidirectionality tests pass. > > We should add it unconditionally. > > Signed-off-by: Felipe Contreras > --- Without knowing t

Re: [PATCH] remote-hg: fix commit messages

2013-04-17 Thread Felipe Contreras
On Thu, Apr 18, 2013 at 1:06 AM, Felipe Contreras wrote: > git fast-import expects an extra newline after the commit message data, > but we are adding it only on hg-git compat mode, which is why the > bidirectionality tests pass. > > We should add it unconditionally. This doesn't depend on any ot

[PATCH] remote-hg: fix commit messages

2013-04-17 Thread Felipe Contreras
git fast-import expects an extra newline after the commit message data, but we are adding it only on hg-git compat mode, which is why the bidirectionality tests pass. We should add it unconditionally. Signed-off-by: Felipe Contreras --- contrib/remote-helpers/git-remote-hg | 3 ++- 1 file chang