Re: [PATCH] rev-parse: Check argc before using argv[i+1]

2014-01-28 Thread Junio C Hamano
David Sharp dhsh...@google.com writes: @@ -738,9 +740,11 @@ int cmd_rev_parse(int argc, const char **argv, const char *prefix) continue; } if (!strcmp(arg, --resolve-git-dir)) { - const

Re: [PATCH] rev-parse: Check argc before using argv[i+1]

2014-01-28 Thread David Sharp
On Tue, Jan 28, 2014 at 11:12 AM, Junio C Hamano gits...@pobox.com wrote: David Sharp dhsh...@google.com writes: @@ -738,9 +740,11 @@ int cmd_rev_parse(int argc, const char **argv, const char *prefix) continue; } if

[PATCH] rev-parse: Check argc before using argv[i+1]

2014-01-27 Thread David Sharp
Without this patch, git-rev-parse --prefix, --default, or --resolve-git-dir, without a value argument, would result in a segfault. Instead, die() with a message. Signed-off-by: David Sharp dhsh...@google.com --- builtin/rev-parse.c | 16 ++-- 1 file changed, 10 insertions(+), 6