Re: [PATCH] status: hint the user about -uno if read_directory takes too long

2013-03-16 Thread Junio C Hamano
Torsten Bögershausen writes: >> Or we can be more explicit and say >> >> # It took 2.58 seconds to search for untracked files. 'status -uno' >> # may speed it up, but you have to be careful not to forget to add >> # new files yourself (see 'git help status'). >> > Thanks, that looks good for m

Re: [PATCH] status: hint the user about -uno if read_directory takes too long

2013-03-16 Thread Torsten Bögershausen
On 15.03.13 22:59, Junio C Hamano wrote: > Torsten Bögershausen writes: > >> Thanks, that looks good to me: >> >> # It took 2.58 seconds to enumerate untracked files. >> # Consider the -u option for a possible speed-up? >> >> But: >> If I follow the advice as is given and use "git status -u", the

Re: [PATCH] status: hint the user about -uno if read_directory takes too long

2013-03-15 Thread Duy Nguyen
On Thu, Mar 14, 2013 at 5:22 PM, Duy Nguyen wrote: > On Wed, Mar 13, 2013 at 11:16 PM, Junio C Hamano wrote: >> The noise this introduces to the test suite is a bit irritating and >> makes us think twice if this really a good change. > > I originally thought of two options, this or add an env fla

Re: [PATCH] status: hint the user about -uno if read_directory takes too long

2013-03-15 Thread Junio C Hamano
Torsten Bögershausen writes: > Thanks, that looks good to me: > > # It took 2.58 seconds to enumerate untracked files. > # Consider the -u option for a possible speed-up? > > But: > If I follow the advice as is given and use "git status -u", the result is the > same. Yeah, that was taken from

Re: [PATCH] status: hint the user about -uno if read_directory takes too long

2013-03-15 Thread Torsten Bögershausen
On 15.03.13 21:06, Junio C Hamano wrote: > Torsten Bögershausen writes: > >> > Thanks, I like that much better than mine >> > (and expere is probably a word not yet invented) > OK, then how about redoing Duy's patch like this on top? > > I've moved the timing collection from the caller to callee

Re: [PATCH] status: hint the user about -uno if read_directory takes too long

2013-03-15 Thread Junio C Hamano
Torsten Bögershausen writes: > Thanks, I like that much better than mine > (and expere is probably a word not yet invented) OK, then how about redoing Duy's patch like this on top? I've moved the timing collection from the caller to callee, and I think the result is more readable. The message

Re: [PATCH] status: hint the user about -uno if read_directory takes too long

2013-03-15 Thread Torsten Bögershausen
On 03/15/2013 05:53 PM, Junio C Hamano wrote: Torsten Bögershausen writes: [PATCH] git status: Document that git status -uno is faster In some repostories users expere that "git status" command takes long time. expere??? Certainly you did not mean "expect". "observe", "experience", or "see

Re: [PATCH] status: hint the user about -uno if read_directory takes too long

2013-03-15 Thread Junio C Hamano
Torsten Bögershausen writes: > [PATCH] git status: Document that git status -uno is faster > > In some repostories users expere that "git status" command takes long time. expere??? Certainly you did not mean "expect". "observe", "experience", or "see", perhaps? > The command spends some time

Re: [PATCH] status: hint the user about -uno if read_directory takes too long

2013-03-15 Thread Ramkumar Ramachandra
Torsten Bögershausen wrote: > [PATCH] git status: Document that git status -uno is faster Yes. I like this patch. > In some repostories users expere that "git status" command takes long time. > The command spends some time searching the file system for untracked files. > Document that searching

Re: [PATCH] status: hint the user about -uno if read_directory takes too long

2013-03-15 Thread Torsten Bögershausen
On 03/15/2013 01:30 PM, Duy Nguyen wrote: On Thu, Mar 14, 2013 at 10:05 PM, Junio C Hamano wrote: "to speed up by stopping displaying untracked files" does not look like giving a balanced suggestion. It is increasing the risk of forgetting about newly created files the user may want to add, bu

Re: [PATCH] status: hint the user about -uno if read_directory takes too long

2013-03-15 Thread Duy Nguyen
On Thu, Mar 14, 2013 at 10:05 PM, Junio C Hamano wrote: >>> "to speed up by stopping displaying untracked files" does not look >>> like giving a balanced suggestion. It is increasing the risk of >>> forgetting about newly created files the user may want to add, but >>> the risk is not properly wa

Re: [PATCH] status: hint the user about -uno if read_directory takes too long

2013-03-14 Thread Junio C Hamano
Duy Nguyen writes: > On Wed, Mar 13, 2013 at 10:21 PM, Torsten Bögershausen wrote: >>> + statusUno:: >>> + If collecting untracked files in linkgit:git-status[1] >>> + takes more than 2 seconds, hint the user that the option >>> + `-uno` could be used to s

Re: [PATCH] status: hint the user about -uno if read_directory takes too long

2013-03-14 Thread Duy Nguyen
On Wed, Mar 13, 2013 at 10:21 PM, Torsten Bögershausen wrote: >> + statusUno:: >> + If collecting untracked files in linkgit:git-status[1] >> + takes more than 2 seconds, hint the user that the option >> + `-uno` could be used to stop collecting untracked fi

Re: [PATCH] status: hint the user about -uno if read_directory takes too long

2013-03-13 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > diff --git a/Documentation/config.txt b/Documentation/config.txt > index bbba728..e91d06f 100644 > --- a/Documentation/config.txt > +++ b/Documentation/config.txt > @@ -178,6 +178,10 @@ advice.*:: > the template shown when writing commit messages in >

Re: [PATCH] status: hint the user about -uno if read_directory takes too long

2013-03-13 Thread Torsten Bögershausen
On 13.03.13 13:59, Nguyễn Thái Ngọc Duy wrote: > This patch attempts to advertise -uno to the users who tolerate slow > "git status" on large repositories (or slow machines/disks). The 2 > seconds limit is quite arbitrary but is probably long enough to start > using -uno. > > Signed-off-by: Nguyễn

[PATCH] status: hint the user about -uno if read_directory takes too long

2013-03-13 Thread Nguyễn Thái Ngọc Duy
This patch attempts to advertise -uno to the users who tolerate slow "git status" on large repositories (or slow machines/disks). The 2 seconds limit is quite arbitrary but is probably long enough to start using -uno. Signed-off-by: Nguyễn Thái Ngọc Duy --- Documentation/config.txt | 4 ad