Re: [PATCH] t/test-lib: print pretty msg when git isn't built

2012-09-18 Thread Junio C Hamano
se your version then. Let me know if you want me to > submit a revised patch. OK, let's do this. -- >8 -- From: Ramkumar Ramachandra Date: Mon, 17 Sep 2012 22:36:19 +0530 Subject: [PATCH] t/test-lib: print pretty msg when git isn't built When tests were run without building

Re: [PATCH] t/test-lib: print pretty msg when git isn't built

2012-09-18 Thread Junio C Hamano
Ramkumar Ramachandra writes: > When tests were run without building git, the following error message > was displayed: > > .: 54: Can't open /path/to/git/source/t/../GIT-BUILD-OPTIONS Does the test stop due to this error, or it just goes on and hit another error? I am guessing that it is the

Re: [PATCH] t/test-lib: print pretty msg when git isn't built

2012-09-18 Thread Ramkumar Ramachandra
Hi Junio, Junio C Hamano wrote: >> Junio C Hamano wrote: >>> Yeah, but why change it so much? Wouldn't writing >>> >>> "$GIT_BUILD_DIR/git" >/dev/null >>> if test $? != 1 >>> then >>> : You haven't built git! >>> fi >>> >>> just like the original in

Re: [PATCH] t/test-lib: print pretty msg when git isn't built

2012-09-18 Thread Junio C Hamano
Ramkumar Ramachandra writes: > Hi, > > Junio C Hamano wrote: >> Ramkumar Ramachandra writes: >> >>> Hi Junio, >>> >>> Junio C Hamano wrote: Is this a sufficient replacement for what you removed from ? Can the BUILD-OPTIONS file exist when your build of git failed? >>> >>> Oops, I d

Re: [PATCH] t/test-lib: print pretty msg when git isn't built

2012-09-18 Thread Ramkumar Ramachandra
Hi, Junio C Hamano wrote: > Ramkumar Ramachandra writes: > >> Hi Junio, >> >> Junio C Hamano wrote: >>> Is this a sufficient replacement for what you removed from ? >>> Can the BUILD-OPTIONS file exist when your build of git failed? >> >> Oops, I didn't realize that BUILD-OPTIONS would be wri

Re: [PATCH] t/test-lib: print pretty msg when git isn't built

2012-09-18 Thread Junio C Hamano
Ramkumar Ramachandra writes: > Hi Junio, > > Junio C Hamano wrote: >> Is this a sufficient replacement for what you removed from ? >> Can the BUILD-OPTIONS file exist when your build of git failed? > > Oops, I didn't realize that BUILD-OPTIONS would be written when the > build fails. How abo

Re: [PATCH] t/test-lib: print pretty msg when git isn't built

2012-09-17 Thread Ramkumar Ramachandra
Hi Junio, Junio C Hamano wrote: > Is this a sufficient replacement for what you removed from ? > Can the BUILD-OPTIONS file exist when your build of git failed? Oops, I didn't realize that BUILD-OPTIONS would be written when the build fails. How about something like this instead: diff --git

Re: [PATCH] t/test-lib: print pretty msg when git isn't built

2012-09-17 Thread Junio C Hamano
Ramkumar Ramachandra writes: > When tests were run without building git, the following error message > was displayed: > > .: 54: Can't open /path/to/git/source/t/../GIT-BUILD-OPTIONS > > Change this to display a more user-friendly error message: > > error: you do not seem to have built g

[PATCH] t/test-lib: print pretty msg when git isn't built

2012-09-17 Thread Ramkumar Ramachandra
When tests were run without building git, the following error message was displayed: .: 54: Can't open /path/to/git/source/t/../GIT-BUILD-OPTIONS Change this to display a more user-friendly error message: error: you do not seem to have built git yet. Signed-off-by: Ramkumar Ramachandra