[PATCH] t7507-*.sh: Fix test #8 (could not run '$FAKE_EDITOR')

2013-11-20 Thread Ramsay Jones
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk --- Hi Jens, commit 61b6a633 (commit -v: strip diffs and submodule shortlogs from the commit message, 19-11-2013) in 'pu' fails the new test it added to t7507. I didn't spend too long looking at the problem, so take this patch as nothing

Re: [PATCH] t7507-*.sh: Fix test #8 (could not run '$FAKE_EDITOR')

2013-11-20 Thread Junio C Hamano
Ramsay Jones ram...@ramsay1.demon.co.uk writes: Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk --- Hi Jens, commit 61b6a633 (commit -v: strip diffs and submodule shortlogs from the commit message, 19-11-2013) in 'pu' fails the new test it added to t7507. I didn't spend too long

Re: [PATCH] t7507-*.sh: Fix test #8 (could not run '$FAKE_EDITOR')

2013-11-20 Thread Junio C Hamano
Jeff King p...@peff.net writes: The test_set_editor helper does some magic to help with quoting, but that should not be an issue in this case (since we are using cat). We are using test_set_editor elsewhere in the script, which would have set EDITOR previously. But I would think that

Re: [PATCH] t7507-*.sh: Fix test #8 (could not run '$FAKE_EDITOR')

2013-11-20 Thread Jeff King
On Wed, Nov 20, 2013 at 10:33:28AM -0800, Junio C Hamano wrote: Jeff King p...@peff.net writes: Am I misremembering the issues with one-shot variables and functions? I think there are two problems involved. OK, I was misremembering. I recalled the does not unset afterwards part, but not

Re: [PATCH] t7507-*.sh: Fix test #8 (could not run '$FAKE_EDITOR')

2013-11-20 Thread Jeff King
On Wed, Nov 20, 2013 at 01:54:20PM -0500, Jeff King wrote: I'm not sure why the old $FAKE_EDITOR doesn't work there, though (not that it would make the test pass anyway, as it does something different than what the test wants, but I would not expect the shell to complain of failure). Oh, I

Re: [PATCH] t7507-*.sh: Fix test #8 (could not run '$FAKE_EDITOR')

2013-11-20 Thread Ramsay Jones
On 20/11/13 17:22, Junio C Hamano wrote: Ramsay Jones ram...@ramsay1.demon.co.uk writes: Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk --- Hi Jens, commit 61b6a633 (commit -v: strip diffs and submodule shortlogs from the commit message, 19-11-2013) in 'pu' fails the new test it

Re: [PATCH] t7507-*.sh: Fix test #8 (could not run '$FAKE_EDITOR')

2013-11-20 Thread Jens Lehmann
Am 20.11.2013 20:35, schrieb Ramsay Jones: On 20/11/13 17:22, Junio C Hamano wrote: Ramsay Jones ram...@ramsay1.demon.co.uk writes: Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk --- Hi Jens, commit 61b6a633 (commit -v: strip diffs and submodule shortlogs from the commit message,