Re: [PATCH] test-bzr: Do not use unportable sed "\+"

2013-05-11 Thread Junio C Hamano
Torsten Bögershausen writes: > On 11.05.13 22:09, Junio C Hamano wrote: >> Torsten Bögershausen writes: >> >>> I did, >>> the interesting thing is that the test passes with and without your patch. >>> (After enabling GIT_TEST_LONG and GIT_TEST_HTTPD in both cases) >> >> Strange. Do you see d

Re: [PATCH] test-bzr: Do not use unportable sed "\+"

2013-05-11 Thread Torsten Bögershausen
On 11.05.13 22:09, Junio C Hamano wrote: > Torsten Bögershausen writes: > >> I did, >> the interesting thing is that the test passes with and without your patch. >> (After enabling GIT_TEST_LONG and GIT_TEST_HTTPD in both cases) > > Strange. Do you see differences between the produced packed-r

RE: [PATCH] test-bzr: Do not use unportable sed "\+"

2013-05-11 Thread Torsten Bögershausen
On 05/11/2013 03:25 PM, Torsten Bögershausen wrote: Sorry, I forgot to mention that there is another test case that fails in test-bzr.sh (Both Linux and MacOS): Cloning into 'gitrepo'... --- ../expected 2013-05-11 20:07:17.678360248 + +++ actual 2013-05-11 20:07:21.510312073 + @@ -1,

Re: [PATCH] test-bzr: Do not use unportable sed "\+"

2013-05-11 Thread Junio C Hamano
Torsten Bögershausen writes: > I did, > the interesting thing is that the test passes with and without your patch. > (After enabling GIT_TEST_LONG and GIT_TEST_HTTPD in both cases) Strange. Do you see differences between the produced packed-refs file? -- To unsubscribe from this list: send the

Re: [PATCH] test-bzr: Do not use unportable sed "\+"

2013-05-11 Thread Torsten Bögershausen
On 11.05.13 21:45, Junio C Hamano wrote: > Junio C Hamano writes: > >> Thanks. Is there another one in t/t5551-http-fetch.sh that checks >> the tags? > > I think your sed will see the same breakage for the one in 5551 (my > sed is unfortunately GNU and ".\+" does not break it). Could you > tes

Re: [PATCH] test-bzr: Do not use unportable sed "\+"

2013-05-11 Thread Junio C Hamano
Junio C Hamano writes: > Thanks. Is there another one in t/t5551-http-fetch.sh that checks > the tags? I think your sed will see the same breakage for the one in 5551 (my sed is unfortunately GNU and ".\+" does not break it). Could you test this patch with: GIT_TEST_LONG=YesPlease GIT_TE

Re: [PATCH] test-bzr: Do not use unportable sed "\+"

2013-05-11 Thread Junio C Hamano
Torsten Bögershausen writes: > Using sed -e '/[0-9]\+//' to find "one ore more" digits > is not portable. > Use the Basic Regular Expression '/[0-9][0-9]*//' instead > > Signed-off-by: Torsten Bögershausen Thanks. Is there another one in t/t5551-http-fetch.sh that checks the tags? > --- > co

[PATCH] test-bzr: Do not use unportable sed "\+"

2013-05-11 Thread Torsten Bögershausen
Using sed -e '/[0-9]\+//' to find "one ore more" digits is not portable. Use the Basic Regular Expression '/[0-9][0-9]*//' instead Signed-off-by: Torsten Bögershausen --- contrib/remote-helpers/test-bzr.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/remote-helpers