[PATCH] test-lib.sh: unfilter GIT_PERF_*
These variables are user parameters to control how to run the perf tests. Allow users to do so. Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com --- t/test-lib.sh | 3 +++ 1 file changed, 3 insertions(+) diff --git a/t/test-lib.sh b/t/test-lib.sh index f50f834..b8d35d1 100644 --- a/t/test-lib.sh +++ b/t/test-lib.sh @@ -86,6 +86,9 @@ unset VISUAL EMAIL LANGUAGE COLUMNS $($PERL_PATH -e ' PROVE VALGRIND PERF_AGGREGATING_LATER + PERF_LARGE_REPO + PERF_REPEAT_COUNT + PERF_REPO )); my @vars = grep(/^GIT_/ !/^GIT_($ok)/o, @env); print join(\n, @vars); -- 1.8.0.rc2.23.g1fb49df -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] test-lib.sh: unfilter GIT_PERF_*
Nguyễn Thái Ngọc Duy pclo...@gmail.com writes:
These variables are user parameters to control how to run the perf
tests. Allow users to do so.
[...]
@@ -86,6 +86,9 @@ unset VISUAL EMAIL LANGUAGE COLUMNS $($PERL_PATH -e '
PROVE
VALGRIND
PERF_AGGREGATING_LATER
+ PERF_LARGE_REPO
+ PERF_REPEAT_COUNT
+ PERF_REPO
));
Wouldn't it be more futureproof to put simply PERF as an entry, and rely
on the leading-match logic
my @vars = grep(/^GIT_/ !/^GIT_($ok)/o, @env);
to allow all GIT_PERF variables?
Other than that, Ack. I never noticed because I set mine through
config.mak, which goes to GIT-BUILD-OPTIONS. Those options are not
exported, which means perl does not pick them up. (That just took me
far too long to realize.)
--
Thomas Rast
trast@{inf,student}.ethz.ch
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] test-lib.sh: unfilter GIT_PERF_*
On Tue, Jan 15, 2013 at 8:43 PM, Thomas Rast tr...@student.ethz.ch wrote: Nguyễn Thái Ngọc Duy pclo...@gmail.com writes: These variables are user parameters to control how to run the perf tests. Allow users to do so. [...] @@ -86,6 +86,9 @@ unset VISUAL EMAIL LANGUAGE COLUMNS $($PERL_PATH -e ' PROVE VALGRIND PERF_AGGREGATING_LATER + PERF_LARGE_REPO + PERF_REPEAT_COUNT + PERF_REPO )); Wouldn't it be more futureproof to put simply PERF as an entry, and rely on the leading-match logic my @vars = grep(/^GIT_/ !/^GIT_($ok)/o, @env); to allow all GIT_PERF variables? Yeah. Other than that, Ack. I never noticed because I set mine through config.mak, which goes to GIT-BUILD-OPTIONS. Those options are not exported, which means perl does not pick them up. (That just took me far too long to realize.) By the way is there an option to skip the first few runs (too lazy to check out the source code, apparently)? I tried linux-2.6 as the large repo and I think the first (cold cache) run ruins the numbers. -- Duy -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
