Re: [PATCH] test-string-list.c: Fix some sparse warnings

2012-09-20 Thread Michael Haggerty
On 09/19/2012 09:07 PM, Ramsay Jones wrote: > Michael Haggerty wrote: >> Is there some documentation about how to run sparse on the git codebase? >> I naively tried "make sparse" and ended up with zillions of errors like >> >> /usr/include/unistd.h:288:54: error: attribute '__leaf__': unknown attr

Re: [PATCH] test-string-list.c: Fix some sparse warnings

2012-09-19 Thread Ramsay Jones
Michael Haggerty wrote: > On 09/15/2012 06:18 PM, Ramsay Jones wrote: >> >> In particular, sparse complains as follows: >> >> SP test-string-list.c >> test-string-list.c:10:6: warning: symbol 'parse_string_list' was not \ >> declared. Should it be static? >> test-string-list

Re: [PATCH] test-string-list.c: Fix some sparse warnings

2012-09-17 Thread Michael Haggerty
On 09/15/2012 06:18 PM, Ramsay Jones wrote: > > In particular, sparse complains as follows: > > SP test-string-list.c > test-string-list.c:10:6: warning: symbol 'parse_string_list' was not \ > declared. Should it be static? > test-string-list.c:18:6: warning: symbol 'write

Re: [PATCH] test-string-list.c: Fix some sparse warnings

2012-09-15 Thread Junio C Hamano
Queued. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] test-string-list.c: Fix some sparse warnings

2012-09-15 Thread Ramsay Jones
In particular, sparse complains as follows: SP test-string-list.c test-string-list.c:10:6: warning: symbol 'parse_string_list' was not \ declared. Should it be static? test-string-list.c:18:6: warning: symbol 'write_list' was not \ declared. Should it be static?