Re: [PATCH] unpack-trees: do not abort when overwriting an existing file with the same content

2013-01-20 Thread Duy Nguyen
On Mon, Jan 21, 2013 at 1:35 AM, Junio C Hamano wrote: > Nguyễn Thái Ngọc Duy writes: > >> + /* >> + * If it has the same content that we are going to write down, > > write down??? hmm.. "overwrite" then. >> + * there's no point in complaining. We still overwrite it in the >> +

Re: [PATCH] unpack-trees: do not abort when overwriting an existing file with the same content

2013-01-20 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > + /* > + * If it has the same content that we are going to write down, write down??? > + * there's no point in complaining. We still overwrite it in the > + * end though. Permission is not checked so it may be lost. > + */ That is a regre

[PATCH] unpack-trees: do not abort when overwriting an existing file with the same content

2013-01-19 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- The "git reset" as illustrated in the test case is one case people may be hit by this. We can also do the same for "uptodate" check, but I'm not sure how that could happen. t/t1011-read-tree-sparse-checkout.sh | 3 ++- t/t2021-checkout-overwrite.sh