Re: [PATCH] web--browse: support /usr/bin/cygstart on Cygwin

2013-07-25 Thread Junio C Hamano
"Yaakov (Cygwin/X)"  writes:

>>> Signed-off-by: Yaakov Selkowitz 
>>
>> Will queue and wait for somebody from Cygwin land to comment.
>
> Ping?  Is there someone in particular whose input you are looking for?

Nobody in particular.  Nobody complained nor reported breakages, so
we are good to go ;-)

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] web--browse: support /usr/bin/cygstart on Cygwin

2013-07-23 Thread Yaakov (Cygwin/X)

On 2013-06-21 11:06, Junio C Hamano wrote:

From: Yaakov Selkowitz 

While both GUI and console Cygwin browsers do exist, anecdotal evidence
suggests most users rely on their native Windows browser.  cygstart,
which is a long-standing part of the base Cygwin installation, will
cause the page to be opened in the default Windows browser (the one
registered to open .html files).

Signed-off-by: Yaakov Selkowitz 


Will queue and wait for somebody from Cygwin land to comment.


Ping?  Is there someone in particular whose input you are looking for?


Yaakov

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] web--browse: support /usr/bin/cygstart on Cygwin

2013-06-21 Thread Junio C Hamano
"Yaakov (Cygwin/X)"  writes:

> From: Yaakov Selkowitz 
>
> While both GUI and console Cygwin browsers do exist, anecdotal evidence
> suggests most users rely on their native Windows browser.  cygstart,
> which is a long-standing part of the base Cygwin installation, will
> cause the page to be opened in the default Windows browser (the one
> registered to open .html files).
>
> Signed-off-by: Yaakov Selkowitz 

Will queue and wait for somebody from Cygwin land to comment.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH] web--browse: support /usr/bin/cygstart on Cygwin

2013-06-21 Thread Yaakov (Cygwin/X)
From: Yaakov Selkowitz 

While both GUI and console Cygwin browsers do exist, anecdotal evidence
suggests most users rely on their native Windows browser.  cygstart,
which is a long-standing part of the base Cygwin installation, will
cause the page to be opened in the default Windows browser (the one
registered to open .html files).

Signed-off-by: Yaakov Selkowitz 
---
 Documentation/git-web--browse.txt | 1 +
 git-web--browse.sh| 9 +++--
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/Documentation/git-web--browse.txt 
b/Documentation/git-web--browse.txt
index ba79cb4..5aec4ec 100644
--- a/Documentation/git-web--browse.txt
+++ b/Documentation/git-web--browse.txt
@@ -34,6 +34,7 @@ The following browsers (or commands) are currently supported:
 * dillo
 * open (this is the default under Mac OS X GUI)
 * start (this is the default under MinGW)
+* cygstart (this is the default under Cygwin)
 
 Custom commands may also be specified.
 
diff --git a/git-web--browse.sh b/git-web--browse.sh
index 9f44679..9fc1dba 100755
--- a/git-web--browse.sh
+++ b/git-web--browse.sh
@@ -33,7 +33,8 @@ valid_tool() {
case "$1" in
firefox | iceweasel | seamonkey | iceape | \
chrome | google-chrome | chromium | chromium-browser |\
-   konqueror | opera | w3m | elinks | links | lynx | dillo | open | start)
+   konqueror | opera | w3m | elinks | links | lynx | dillo | open |\
+   start | cygstart)
;; # happy
*)
valid_custom_tool "$1" || return 1
@@ -127,6 +128,10 @@ if test -z "$browser" ; then
if test -x /bin/start; then
browser_candidates="start $browser_candidates"
fi
+   # /usr/bin/cygstart indicates Cygwin
+   if test -x /usr/bin/cygstart; then
+   browser_candidates="cygstart $browser_candidates"
+   fi
 
for i in $browser_candidates; do
init_browser_path $i
@@ -174,7 +179,7 @@ konqueror)
;;
esac
;;
-w3m|elinks|links|lynx|open)
+w3m|elinks|links|lynx|open|cygstart)
"$browser_path" "$@"
;;
 start)
-- 
1.8.3

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html