Re: [PATCH 0/2] branch: improve verbose option

2013-08-31 Thread Felipe Contreras
On Sat, Aug 31, 2013 at 9:41 AM, Philip Oakley  wrote:
> From: "Felipe Contreras" 

>>Showing ahead/behind is
>> not as important,
>
>
> I still find this useful - if it's up to date I don't need reminding of
> which remote / upstream tracking branch it's configured against ;-)

Whether or not it's up to date depends on which is the upstream
tracking branch. What if you see "ahead 1", and you think it's not up
to date, but it turns out it's tracking the wrong branch?

> These two bits of information, while related are separate. If anything I
> think I'd prefer both, but then again optimisations are still good.

So you can keep using 'git branch -vv'.

-- 
Felipe Contreras
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 0/2] branch: improve verbose option

2013-08-31 Thread Philip Oakley

From: "Felipe Contreras" 
Sent: Friday, August 30, 2013 11:59 PM

Hi,

This has been discussed before:

http://thread.gmane.org/gmane.comp.version-control.git/224489

but in the spirit of the perfect being the enemy of the good, nothing 
got done.


This series makes 'git branch -v' much faster, and gives us the most 
important

information; the configured upstream tracking branch.


Yes, It's someting I often want reminding of (which origin server, which 
master?, ..etc.) always appear to start here.



   Showing ahead/behind is
not as important,


I still find this useful - if it's up to date I don't need reminding of 
which remote / upstream tracking branch it's configured against ;-)


These two bits of information, while related are separate. If anything I 
think I'd prefer both, but then again optimisations are still good.


Bikeshedding ends.

Philip


   specially considering that currently 'git branch -v' doesn't
show the branch we are comparing the ahead/behind to.

Strictly speaking it's a regression, but nobody would complain, and if 
somebody

does, it should be easy to revert if needed.

Felipe Contreras (2):
 branch: trivial cleanup
 branch: reorganize verbose options

builtin/branch.c | 33 +++--
t/t6040-tracking-info.sh |  8 
2 files changed, 19 insertions(+), 22 deletions(-)

--


--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH 0/2] branch: improve verbose option

2013-08-30 Thread Felipe Contreras
Hi,

This has been discussed before:

http://thread.gmane.org/gmane.comp.version-control.git/224489

but in the spirit of the perfect being the enemy of the good, nothing got done.

This series makes 'git branch -v' much faster, and gives us the most important
information; the configured upstream tracking branch. Showing ahead/behind is
not as important, specially considering that currently 'git branch -v' doesn't
show the branch we are comparing the ahead/behind to.

Strictly speaking it's a regression, but nobody would complain, and if somebody
does, it should be easy to revert if needed.

Felipe Contreras (2):
  branch: trivial cleanup
  branch: reorganize verbose options

 builtin/branch.c | 33 +++--
 t/t6040-tracking-info.sh |  8 
 2 files changed, 19 insertions(+), 22 deletions(-)

-- 
1.8.4-fc

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html