On 07/17/2013 07:04 PM, Junio C Hamano wrote:
> Builtins link all sorts of stuff from outside, e.g. diff.c and
> diffcore-*.c at the toplevel. I do not see diff_no_index.c is any
> different, so I am probably not understanding your question.
Thanks for the explanation. I am not yet very used to
On Wed, Jul 17, 2013 at 10:04 AM, Junio C Hamano wrote:
> If we wanted to make "-q" follow the spirit of its original addition
> to "show-diff" again, we could internally add a diff-filter when the
> "-q" option is parsed.
Having said all that, I do not mean to advocate to retain "-q". Most
likel
Stefan Beller writes:
> The changes in the following patch are in diff_no_index.c, but the
> diff_no_index(...) is called from cmd_diff, which is in builtin/diff.c
> That cmd_diff is actually called from git.c having the
> { "diff", cmd_diff }, entry in handle_internal_command.
>
> My question no
On 07/15/2013 12:07 AM, Jonathan Nieder wrote:
> This feature was obviously never tested with --no-index, so I agree it
> makes sense to remove it. Probably the commit message and a comment
> should say so, though. E.g.:
>
> diff --no-index: remove nonfunctional "-q" handling
>
> Befo
4 matches
Mail list logo