Re: [PATCH 0/3] Remove sq_quote_print() in favor of *_buf

2013-07-30 Thread Ramkumar Ramachandra
Junio C Hamano wrote: > Having said all that, the patch texts all look OK, so I'll queue > them with updated log messages. It was the usual me reacting to > unjustified value judgement made in log messages and cover letters. Thanks. I'll look at how the log messages are different in the queued v

Re: [PATCH 0/3] Remove sq_quote_print() in favor of *_buf

2013-07-30 Thread Junio C Hamano
Junio C Hamano writes: > Ramkumar Ramachandra writes: > >> While going through the for-each-ref-pretty series that Duy and I were >> developing, I noticed that this cleanup was independent and good >> as-it-is. >> >> So here it is. > > You always can first allocate a piece of memory and write in

Re: [PATCH 0/3] Remove sq_quote_print() in favor of *_buf

2013-07-30 Thread Junio C Hamano
Ramkumar Ramachandra writes: > While going through the for-each-ref-pretty series that Duy and I were > developing, I noticed that this cleanup was independent and good > as-it-is. > > So here it is. You always can first allocate a piece of memory and write into it instead of writing things out

[PATCH 0/3] Remove sq_quote_print() in favor of *_buf

2013-07-30 Thread Ramkumar Ramachandra
Hi, While going through the for-each-ref-pretty series that Duy and I were developing, I noticed that this cleanup was independent and good as-it-is. So here it is. Nguyễn Thái Ngọc Duy (1): for-each-ref, quote: convert *_quote_print -> *_quote_buf Ramkumar Ramachandra (2): tar-tree: remove