Re: [PATCH 0/3] null sha1 in trees

2012-07-30 Thread Jeff King
On Sun, Jul 29, 2012 at 03:15:11PM -0700, Junio C Hamano wrote: > All looked reasonable, even though I'd want to read the > surrounding codepath over for 2/3 a few more times. > > Will queue; thanks. Yeah, 2/3 is the one that gives me the most pause. I originally assumed we would never want to p

Re: [PATCH 0/3] null sha1 in trees

2012-07-29 Thread Junio C Hamano
All looked reasonable, even though I'd want to read the surrounding codepath over for 2/3 a few more times. Will queue; thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/ma

[PATCH 0/3] null sha1 in trees

2012-07-28 Thread Jeff King
I recently came across a tree in the wild that had a submodule entry whose sha1 was the null sha1 (i.e., all-zeros). It triggered an interesting bug in the diff code, which is fixed by patch 1. Unfortunately, I have no clue how this tree came about. I'm assuming it was simply a bug somewhere in gi