Re: [PATCH 00/12] Fix some reference-related races

2013-06-18 Thread Ramsay Jones
Michael Haggerty wrote: Thanks for all of the information. On 06/15/2013 10:13 PM, Ramsay Jones wrote: Michael Haggerty wrote: *This patch series must be built on top of mh/reflife.* [ ... ] You may be wondering why clear_packed_ref_cache() is called? Well, that is because

Re: [PATCH 00/12] Fix some reference-related races

2013-06-18 Thread Michael Haggerty
On 06/18/2013 08:13 PM, Ramsay Jones wrote: Michael Haggerty wrote: On 06/15/2013 10:13 PM, Ramsay Jones wrote: Now, turning to the new code, t3211-peel-ref.sh test #7 now works, but test #8 still fails... [ ... ] It should be impossible, because the current process is

Re: [PATCH 00/12] Fix some reference-related races

2013-06-15 Thread Ramsay Jones
Michael Haggerty wrote: *This patch series must be built on top of mh/reflife.* [...] The other problem was that the for_each_ref() functions will die if the ref cache that they are iterating over is freed out from under them. This problem is solved by using reference counts to avoid

Re: [PATCH 00/12] Fix some reference-related races

2013-06-15 Thread Michael Haggerty
Thanks for all of the information. On 06/15/2013 10:13 PM, Ramsay Jones wrote: Michael Haggerty wrote: *This patch series must be built on top of mh/reflife.* [...] The other problem was that the for_each_ref() functions will die if the ref cache that they are iterating over is freed

Re: [PATCH 00/12] Fix some reference-related races

2013-06-12 Thread Jeff King
On Tue, Jun 11, 2013 at 11:48:20PM +0200, Michael Haggerty wrote: *This patch series must be built on top of mh/reflife.* Applying on top of what Junio has in mh/reflife seems to create conflicts at the first patch. I didn't look into it, though, but just read the patches and looked at the