[PATCH 01/14] t3905-stash-include-untracked.sh: use the $( ... ) construct for command substitution

2014-04-30 Thread Elia Pinto
The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular,

Re: [PATCH 01/14] t3905-stash-include-untracked.sh: use the $( ... ) construct for command substitution

2014-04-30 Thread Matthieu Moy
Patches 1/14 are Reviewed-by: Matthieu Moy matthieu@imag.fr On a side note, reviewing patches by batches of 14 patches actually turns out to be much less convenient for me than reviewing larger batches. If I'm counting correctly, there should be around 100 patches remaining. I'd suggest

Re: [PATCH 01/14] t3905-stash-include-untracked.sh: use the $( ... ) construct for command substitution

2014-04-30 Thread Junio C Hamano
Matthieu Moy matthieu@grenoble-inp.fr writes: Patches 1/14 are Reviewed-by: Matthieu Moy matthieu@imag.fr On a side note, reviewing patches by batches of 14 patches actually turns out to be much less convenient for me than reviewing larger batches. If I'm counting correctly,