Re: [PATCH 01/16] t/t5505-remote: modernize subshell-style of one test

2013-06-22 Thread Ramkumar Ramachandra
Junio C Hamano wrote: Good, but a style only patch like this should consider taking advantage of the occasion to clean up the entire file, as we do not often get enough chance to do so without conflicting with in-flight topics. Is there something else that would conflict if this step did so?

[PATCH 01/16] t/t5505-remote: modernize subshell-style of one test

2013-06-21 Thread Ramkumar Ramachandra
Since we plan to edit the test migrate a remote from named file in $GIT_DIR/remotes in later patches, modernize the subshell-style by putting the parenthesis on separate lines and indenting the body. Signed-off-by: Ramkumar Ramachandra artag...@gmail.com --- t/t5505-remote.sh | 16

Re: [PATCH 01/16] t/t5505-remote: modernize subshell-style of one test

2013-06-21 Thread Junio C Hamano
Ramkumar Ramachandra artag...@gmail.com writes: Since we plan to edit the test migrate a remote from named file in $GIT_DIR/remotes in later patches, modernize the subshell-style by putting the parenthesis on separate lines and indenting the body. Signed-off-by: Ramkumar Ramachandra