Re: [PATCH 01/19] check_bindir: convert test -a/-o to && and ||

2014-05-20 Thread Junio C Hamano
Junio C Hamano writes: > As I already said, I think "better known" is much less of an issue > than that "-a/-o" is "more error prone", and that is the reason why > we may want to do this rewrite. > > I do not know offhand how busy the tree would be when we can apply > these patches post-release w

Re: [PATCH 01/19] check_bindir: convert test -a/-o to && and ||

2014-05-20 Thread Junio C Hamano
Elia Pinto writes: > The interaction with unary operators and operator precedence > for && and || are better known than -a and -o, and for that > reason we prefer them. Replace all existing instances > of -a and -o to save readers from the burden of thinking > about such things. > > Signed-off-by

[PATCH 01/19] check_bindir: convert test -a/-o to && and ||

2014-05-20 Thread Elia Pinto
The interaction with unary operators and operator precedence for && and || are better known than -a and -o, and for that reason we prefer them. Replace all existing instances of -a and -o to save readers from the burden of thinking about such things. Signed-off-by: Elia Pinto --- check_bindir |