Re: [PATCH 01/23] pack v4: initial pack dictionary structure and code

2013-08-27 Thread Nicolas Pitre
On Tue, 27 Aug 2013, Junio C Hamano wrote: > Nicolas Pitre writes: > > > Signed-off-by: Nicolas Pitre > > --- > > Was there a reason not to reuse the hash-table Linus did in > hash.[ch]? Well... Most likely because when I started that code (which used to be quite different initially) it migh

Re: [PATCH 01/23] pack v4: initial pack dictionary structure and code

2013-08-27 Thread Junio C Hamano
Nicolas Pitre writes: > Signed-off-by: Nicolas Pitre > --- Was there a reason not to reuse the hash-table Linus did in hash.[ch]? It may not make much of a difference for something so small and isolated from the rest of the system, but if hash.[ch] can be easily fixed with a small tweak to sui

[PATCH 01/23] pack v4: initial pack dictionary structure and code

2013-08-26 Thread Nicolas Pitre
Signed-off-by: Nicolas Pitre --- packv4-create.c | 137 1 file changed, 137 insertions(+) create mode 100644 packv4-create.c diff --git a/packv4-create.c b/packv4-create.c new file mode 100644 index 000..2de6d41 --- /dev/null +++ b/pa