Re: [PATCH 02/15] commit: push commit_index update into alloc_commit_node

2014-06-10 Thread Junio C Hamano
Jeff King p...@peff.net writes: This will make the alloc_report output a little uglier (it will say raw_commit), but I don't think anyone cares. And I wanted to make sure there wasn't an easy way to accidentally call the wrong alloc function that doesn't handle the index. Thanks; I like this

[PATCH 02/15] commit: push commit_index update into alloc_commit_node

2014-06-09 Thread Jeff King
Whenever we create a commit object via lookup_commit, we give it a unique index to be used with the commit-slab API. The theory is that any struct commit we create would follow this code path, so any such struct would get an index. However, callers could use alloc_commit_node() directly (and get