Re: [PATCH 05/12] refs.c: pass NULL as *flags to read_ref_full

On Tue, Jul 22, 2014 at 11:19 AM, Ronnie Sahlberg wrote: > On Fri, Jul 18, 2014 at 3:31 PM, Junio C Hamano wrote: >> Ronnie Sahlberg writes: >> >>> We call read_ref_full with a pointer to flags from rename_ref but since >>> we never actually use the returned flags we can just pass NULL here inst

Re: [PATCH 05/12] refs.c: pass NULL as *flags to read_ref_full

On Fri, Jul 18, 2014 at 3:31 PM, Junio C Hamano wrote: > Ronnie Sahlberg writes: > >> We call read_ref_full with a pointer to flags from rename_ref but since >> we never actually use the returned flags we can just pass NULL here instead. > > Sensible, at least for the current callers. I had to w

Re: [PATCH 05/12] refs.c: pass NULL as *flags to read_ref_full

Ronnie Sahlberg writes: > We call read_ref_full with a pointer to flags from rename_ref but since > we never actually use the returned flags we can just pass NULL here instead. Sensible, at least for the current callers. I had to wonder if rename_ref() would never want to take advantage of the

[PATCH 05/12] refs.c: pass NULL as *flags to read_ref_full

We call read_ref_full with a pointer to flags from rename_ref but since we never actually use the returned flags we can just pass NULL here instead. Reviewed-by: Jonathan Nieder Signed-off-by: Ronnie Sahlberg --- refs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/refs.c