Re: [PATCH 05/16] remote: remove dead code in read_branches_file()

2013-06-23 Thread Junio C Hamano
Ramkumar Ramachandra artag...@gmail.com writes: Reminds me of the strategy to deprecate functionality in X (cf. http://lwn.net/Articles/536520/) ;-) Leaving dead code around to confuse readers? :\ Did you actually read what was quoted? We broke the use case to access jgarzik/netdev-2.6 only

Re: [PATCH 05/16] remote: remove dead code in read_branches_file()

2013-06-23 Thread Ramkumar Ramachandra
Junio C Hamano wrote: Reminds me of the strategy to deprecate functionality in X (cf. http://lwn.net/Articles/536520/) ;-) Leaving dead code around to confuse readers? :\ We broke the use case to access jgarzik/netdev-2.6 only by having jgarzik remote accidentally, and waited for quite a

Re: [PATCH 05/16] remote: remove dead code in read_branches_file()

2013-06-23 Thread Junio C Hamano
Ramkumar Ramachandra artag...@gmail.com writes: Junio C Hamano wrote: Reminds me of the strategy to deprecate functionality in X (cf. http://lwn.net/Articles/536520/) ;-) Leaving dead code around to confuse readers? :\ We broke the use case to access jgarzik/netdev-2.6 only by having

Re: [PATCH 05/16] remote: remove dead code in read_branches_file()

2013-06-22 Thread Ramkumar Ramachandra
Junio C Hamano wrote: As far as I can tell, that valid-remote-nick was done in df93e33c (Validate nicknames of remote branches to prohibit confusing ones, 2008-02-15), and back in that version, the codepath and the feature that wants to see a slash and do magical things, which is described by

[PATCH 05/16] remote: remove dead code in read_branches_file()

2013-06-21 Thread Ramkumar Ramachandra
The first line of the function checks that the remote-name contains a slash ('/'), and sets the slash variable accordingly. The only caller of read_branches_file() is remote_get_1(); the calling codepath is guarded by valid_remote_nick(), which checks that the remote does not contain a slash.

Re: [PATCH 05/16] remote: remove dead code in read_branches_file()

2013-06-21 Thread Junio C Hamano
Ramkumar Ramachandra artag...@gmail.com writes: The first line of the function checks that the remote-name contains a slash ('/'), and sets the slash variable accordingly. The only caller of read_branches_file() is remote_get_1(); the calling codepath is guarded by valid_remote_nick(), which