Hi Junio,
On Tue, 30 Aug 2016, Junio C Hamano wrote:
> Johannes Schindelin writes:
>
> > @@ -811,13 +813,18 @@ static int populate_opts_cb(const char *key, const
> > char *value, void *data)
> > opts->allow_ff = git_config_bool_or_int(key, value,
> > &error_flag);
> > else if
Johannes Sixt writes:
> Am 30.08.2016 um 19:52 schrieb Johannes Schindelin:
>> Right, but that is exactly what I wanted to avoid, because it is rather
>> inelegant to strdup() strings just so that we do not have to record what
>> to free() and what not to free().
>
> Please, excuse, but when I ha
W dniu 30.08.2016 o 19:52, Johannes Schindelin pisze:
> Hi Kuba,
>
> On Tue, 30 Aug 2016, Jakub Narębski wrote:
>
>> W dniu 29.08.2016 o 10:04, Johannes Schindelin pisze:
>>
>>> The sequencer reads options from disk and stores them in its struct
>>> for use during sequencer's operations.
>>>
>>>
Am 30.08.2016 um 19:52 schrieb Johannes Schindelin:
Right, but that is exactly what I wanted to avoid, because it is rather
inelegant to strdup() strings just so that we do not have to record what
to free() and what not to free().
Please, excuse, but when I have to choose what is more "elegant"
Johannes Schindelin writes:
> @@ -811,13 +813,18 @@ static int populate_opts_cb(const char *key, const char
> *value, void *data)
> opts->allow_ff = git_config_bool_or_int(key, value,
> &error_flag);
> else if (!strcmp(key, "options.mainline"))
> opts->mainline
Hi Kuba,
On Tue, 30 Aug 2016, Jakub Narębski wrote:
> W dniu 29.08.2016 o 10:04, Johannes Schindelin pisze:
>
> > The sequencer reads options from disk and stores them in its struct
> > for use during sequencer's operations.
> >
> > With this patch, the memory is released afterwards, plugging a
W dniu 29.08.2016 o 10:04, Johannes Schindelin pisze:
> The sequencer reads options from disk and stores them in its struct
> for use during sequencer's operations.
>
> With this patch, the memory is released afterwards, plugging a
> memory leak.
>
> Signed-off-by: Johannes Schindelin
> ---
>
The sequencer reads options from disk and stores them in its struct
for use during sequencer's operations.
With this patch, the memory is released afterwards, plugging a
memory leak.
Signed-off-by: Johannes Schindelin
---
sequencer.c | 13 ++---
1 file changed, 10 insertions(+), 3 delet
8 matches
Mail list logo
