Re: [PATCH 08/22] sequencer: remove overzealous assumption

2016-09-01 Thread Jakub Narębski
Hello Johannes, W dniu 01.09.2016 o 10:01, Johannes Schindelin pisze: > On Wed, 31 Aug 2016, Jakub Narębski wrote: >> W dniu 31.08.2016 o 20:36, Johannes Schindelin pisze: >> >> I wonder: would 'git cherry-pick --continue' be able to finish >> 'git revert', and vice versa, then? Or 'git sequencer

Re: [PATCH 08/22] sequencer: remove overzealous assumption

2016-09-01 Thread Johannes Schindelin
Hi Junio, On Wed, 31 Aug 2016, Junio C Hamano wrote: > Johannes Schindelin writes: > > > So if you must have a patch that disagrees with this overzealous > > check, the "revamp todo parsing" one is probably the first. But it is > > better to think of this at a higher level than just patches: it

Re: [PATCH 08/22] sequencer: remove overzealous assumption

2016-09-01 Thread Johannes Schindelin
Hi Kuba, On Wed, 31 Aug 2016, Jakub Narębski wrote: > W dniu 31.08.2016 o 20:36, Johannes Schindelin pisze: > > I wonder: would 'git cherry-pick --continue' be able to finish > 'git revert', and vice versa, then? Or 'git sequencer --continue'? I just tested this, via diff --git a/t/t3

Re: [PATCH 08/22] sequencer: remove overzealous assumption

2016-08-31 Thread Junio C Hamano
Johannes Schindelin writes: > The problem is that the `git-rebase-todo` most definitely does *not* want > to be restricted to a single command. Looking at the test in question, it is about what happens when "git cherry-pick A..B" runs, and the test assumes it gets a sequence of "pick". It would

Re: [PATCH 08/22] sequencer: remove overzealous assumption

2016-08-31 Thread Jakub Narębski
Hello Johannes, W dniu 31.08.2016 o 20:36, Johannes Schindelin pisze: > On Wed, 31 Aug 2016, Jakub Narębski wrote: >> W dniu 29.08.2016 o 10:04, Johannes Schindelin pisze: > I am of the opinion that overzealous checking of certain implementation > details is something to be avoided. I agree.

Re: [PATCH 08/22] sequencer: remove overzealous assumption

2016-08-31 Thread Johannes Schindelin
Hi Kuba, On Wed, 31 Aug 2016, Jakub Narębski wrote: > W dniu 29.08.2016 o 10:04, Johannes Schindelin pisze: > > The sequencer was introduced to make the cherry-pick and revert > > functionality available as library function, with the original idea > > being to extend the sequencer to also impleme

Re: [PATCH 08/22] sequencer: remove overzealous assumption

2016-08-31 Thread Jakub Narębski
W dniu 29.08.2016 o 10:04, Johannes Schindelin pisze: > The sequencer was introduced to make the cherry-pick and revert > functionality available as library function, with the original idea > being to extend the sequencer to also implement the rebase -i > functionality. > > The test to ensure that

[PATCH 08/22] sequencer: remove overzealous assumption

2016-08-29 Thread Johannes Schindelin
The sequencer was introduced to make the cherry-pick and revert functionality available as library function, with the original idea being to extend the sequencer to also implement the rebase -i functionality. The test to ensure that all of the commands in the script are identical to the overall op