Re: [PATCH 09/22] sequencer: completely revamp the "todo" script parsing

2016-09-09 Thread Johannes Schindelin
Hi Kuba, On Fri, 2 Sep 2016, Jakub Narębski wrote: > W dniu 01.09.2016 o 09:49, Johannes Schindelin pisze: > > On Wed, 31 Aug 2016, Jakub Narębski wrote: > > >> Here todo_list uses growable array implementation of list. Which is > >> I guess better on current CPU architecture, with slow

Re: [PATCH 09/22] sequencer: completely revamp the "todo" script parsing

2016-09-01 Thread Jakub Narębski
Hello Johannes, W dniu 01.09.2016 o 09:49, Johannes Schindelin pisze: > On Wed, 31 Aug 2016, Jakub Narębski wrote: >> W dniu 29.08.2016 o 10:05, Johannes Schindelin pisze: [...] >> Hmmm... commit_list is, as defined in commit.h, a linked list. > > That is the most prominent reason why the rest

Re: [PATCH 09/22] sequencer: completely revamp the "todo" script parsing

2016-09-01 Thread Junio C Hamano
Johannes Schindelin writes: >> git continue as a shorthand for `git --continue` sounds great. > > Before we get ahead of ourselves: > > 1) this has nothing to do with the patch series at hand, and > > 2) if we were to introduce `git continue`, we would need to think

Re: [PATCH 09/22] sequencer: completely revamp the "todo" script parsing

2016-09-01 Thread Johannes Schindelin
Hi Kuba, On Wed, 31 Aug 2016, Jakub Narębski wrote: > W dniu 29.08.2016 o 10:05, Johannes Schindelin pisze: > > > When we came up with the "sequencer" idea, we really wanted to have > > kind of a plumbing equivalent of the interactive rebase. Hence the > > choice of words: the "todo" script, a

Re: [PATCH 09/22] sequencer: completely revamp the "todo" script parsing

2016-09-01 Thread Johannes Schindelin
Hi Kuba and Stefan, On Wed, 31 Aug 2016, Stefan Beller wrote: > On Wed, Aug 31, 2016 at 10:29 AM, Jakub Narębski wrote: > > > > > BTW. perhaps we would be able to continue with 'git continue', regardless > > of what we have started with, I wonder... > > > > git continue as a

Re: [PATCH 09/22] sequencer: completely revamp the "todo" script parsing

2016-08-31 Thread Stefan Beller
On Wed, Aug 31, 2016 at 10:29 AM, Jakub Narębski wrote: > > BTW. perhaps we would be able to continue with 'git continue', regardless > of what we have started with, I wonder... > git continue as a shorthand for `git --continue` sounds great. If we were to introduce that, I

Re: [PATCH 09/22] sequencer: completely revamp the "todo" script parsing

2016-08-31 Thread Jakub Narębski
W dniu 29.08.2016 o 10:05, Johannes Schindelin pisze: > When we came up with the "sequencer" idea, we really wanted to have > kind of a plumbing equivalent of the interactive rebase. Hence the > choice of words: the "todo" script, a "pick", etc. > > However, when it came time to implement the

[PATCH 09/22] sequencer: completely revamp the "todo" script parsing

2016-08-29 Thread Johannes Schindelin
When we came up with the "sequencer" idea, we really wanted to have kind of a plumbing equivalent of the interactive rebase. Hence the choice of words: the "todo" script, a "pick", etc. However, when it came time to implement the entire shebang, somehow this idea got lost and the sequencer was