Re: [PATCH 1/1] config: add documentation to config.h

2019-10-22 Thread Emily Shaffer
On Sun, Oct 20, 2019 at 09:35:17PM +1300, Heba Waly wrote: > On Sat, Oct 19, 2019 at 11:52 AM Emily Shaffer > wrote: > > > > On Fri, Oct 18, 2019 at 12:06:59AM +, Heba Waly via GitGitGadget wrote: > > > From: Heba Waly > > > > Hi Heba, > > > > Thanks for the patch! > > > > I'd like to highli

Re: [PATCH 1/1] config: add documentation to config.h

2019-10-20 Thread Heba Waly
On Sat, Oct 19, 2019 at 11:52 AM Emily Shaffer wrote: > > On Fri, Oct 18, 2019 at 12:06:59AM +, Heba Waly via GitGitGadget wrote: > > From: Heba Waly > > Hi Heba, > > Thanks for the patch! > > I'd like to highlight to the community that this is an Outreachy > applicant and microproject. Heba,

Re: [PATCH 1/1] config: add documentation to config.h

2019-10-20 Thread Heba Waly
On Sat, Oct 19, 2019 at 11:07 AM Jonathan Tan wrote: > > > From: Heba Waly > > > > This commit is copying and summarizing the documentation from > > documentation/technical/api-config.txt to comments in config.h > > Thanks for this commit! > > As for your commit message, as far as I know, the ide

Re: [PATCH 1/1] config: add documentation to config.h

2019-10-18 Thread Emily Shaffer
On Fri, Oct 18, 2019 at 12:06:59AM +, Heba Waly via GitGitGadget wrote: > From: Heba Waly Hi Heba, Thanks for the patch! I'd like to highlight to the community that this is an Outreachy applicant and microproject. Heba, when you send the next version, I think you can add [Outreachy] manuall

Re: [PATCH 1/1] config: add documentation to config.h

2019-10-18 Thread Jonathan Tan
> From: Heba Waly > > This commit is copying and summarizing the documentation from > documentation/technical/api-config.txt to comments in config.h Thanks for this commit! As for your commit message, as far as I know, the idea is to move the documentation, not to copy it. Also, write this in i

[PATCH 1/1] config: add documentation to config.h

2019-10-17 Thread Heba Waly via GitGitGadget
From: Heba Waly This commit is copying and summarizing the documentation from documentation/technical/api-config.txt to comments in config.h Signed-off-by: Heba Waly --- config.h | 327 +++ 1 file changed, 327 insertions(+) diff --git a/conf