Re: [PATCH 1/2] build: generate test scripts

2013-06-07 Thread Junio C Hamano
Felipe Contreras writes: > It is generated, in next. If it's not generated, there's no need to > add it to NO_INSTALL. OK, that makes sense. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at htt

Re: [PATCH 1/2] build: generate test scripts

2013-06-07 Thread Felipe Contreras
On Fri, Jun 7, 2013 at 5:40 PM, Junio C Hamano wrote: > Felipe Contreras writes: > >>> Perhaps like this? >>> >>> Makefile | 3 ++- >>> 1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/Makefile b/Makefile >>> index a748133..03fda50 100644 >>> --- a/Makefile >>> +++ b/Makefile

Re: [PATCH 1/2] build: generate test scripts

2013-06-07 Thread Junio C Hamano
Felipe Contreras writes: >> Perhaps like this? >> >> Makefile | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/Makefile b/Makefile >> index a748133..03fda50 100644 >> --- a/Makefile >> +++ b/Makefile >> @@ -2239,6 +2239,7 @@ endif >> >> test_bindir_programs := $(pat

Re: [PATCH 1/2] build: generate test scripts

2013-06-07 Thread Felipe Contreras
On Fri, Jun 7, 2013 at 5:28 PM, Junio C Hamano wrote: > Felipe Contreras writes: > >> On Fri, Jun 7, 2013 at 5:03 PM, Felipe Contreras >> wrote: >> >>> -all:: $(ALL_PROGRAMS) $(SCRIPT_LIB) $(BUILT_INS) $(OTHER_PROGRAMS) >>> GIT-BUILD-OPTIONS >>> +all:: $(ALL_PROGRAMS) $(SCRIPTS_GEN) $(SCRIPT_LI

Re: [PATCH 1/2] build: generate test scripts

2013-06-07 Thread Junio C Hamano
Felipe Contreras writes: > On Fri, Jun 7, 2013 at 5:03 PM, Felipe Contreras > wrote: > >> -all:: $(ALL_PROGRAMS) $(SCRIPT_LIB) $(BUILT_INS) $(OTHER_PROGRAMS) >> GIT-BUILD-OPTIONS >> +all:: $(ALL_PROGRAMS) $(SCRIPTS_GEN) $(SCRIPT_LIB) $(BUILT_INS) >> $(OTHER_PROGRAMS) GIT-BUILD-OPTIONS > > Alte

Re: [PATCH 1/2] build: generate test scripts

2013-06-07 Thread Felipe Contreras
On Fri, Jun 7, 2013 at 5:03 PM, Felipe Contreras wrote: > -all:: $(ALL_PROGRAMS) $(SCRIPT_LIB) $(BUILT_INS) $(OTHER_PROGRAMS) > GIT-BUILD-OPTIONS > +all:: $(ALL_PROGRAMS) $(SCRIPTS_GEN) $(SCRIPT_LIB) $(BUILT_INS) > $(OTHER_PROGRAMS) GIT-BUILD-OPTIONS Alternatively, we could add $(NO_INSTALL) h

[PATCH 1/2] build: generate test scripts

2013-06-07 Thread Felipe Contreras
Commit 416fda6 (build: do not install git-remote-testpy) made it so git-remote-testpy is not only not installed, but also not generated by default, let's make sure all the scripts are generated. Signed-off-by: Felipe Contreras --- Makefile | 7 ++- 1 file changed, 6 insertions(+), 1 deletion