[PATCH 1/2] config: be strict on core.commentChar

2014-05-16 Thread Nguyễn Thái Ngọc Duy
We don't support comment _strings_ (at least not yet). And multi-byte character encoding could also be misinterpreted. The test with two commas is deleted because it violates this. It's added with the patch that introduces core.commentChar in eff80a9 (Allow custom comment char - 2013-01-16). It's

RE: [PATCH 1/2] config: be strict on core.commentChar

2014-05-16 Thread Felipe Contreras
Nguyễn Thái Ngọc Duy wrote: We don't support comment _strings_ (at least not yet). And multi-byte character encoding could also be misinterpreted. The test with two commas is deleted because it violates this. It's added with the patch that introduces core.commentChar in eff80a9 (Allow

Re: [PATCH 1/2] config: be strict on core.commentChar

2014-05-16 Thread Jonathan Nieder
Nguyễn Thái Ngọc Duy wrote: --- a/config.c +++ b/config.c @@ -826,8 +826,12 @@ static int git_default_core_config(const char *var, const char *value) if (!strcmp(var, core.commentchar)) { const char *comment; int ret = git_config_string(comment, var,

Re: [PATCH 1/2] config: be strict on core.commentChar

2014-05-16 Thread Junio C Hamano
Jonathan Nieder jrnie...@gmail.com writes: Nguyễn Thái Ngọc Duy wrote: --- a/config.c +++ b/config.c @@ -826,8 +826,12 @@ static int git_default_core_config(const char *var, const char *value) if (!strcmp(var, core.commentchar)) { const char *comment; int