Re: [PATCH 1/2] pack-refs: write peeled entry for non-tags

2013-03-17 Thread Jeff King
On Sat, Mar 16, 2013 at 02:50:56PM +0100, Michael Haggerty wrote: @@ -39,14 +40,13 @@ static int handle_one_ref(const char *path, const unsigned char *sha1, return 0; fprintf(cb-refs_file, %s %s\n, sha1_to_hex(sha1), path); - if (is_tag_ref) { - struct

[PATCH 1/2] pack-refs: write peeled entry for non-tags

2013-03-16 Thread Jeff King
When we pack an annotated tag ref, we write not only the sha1 of the tag object along with the ref, but also the sha1 obtained by peeling the tag. This lets readers of the pack-refs file know the peeled value without having to actually load the object, speeding up upload-pack's ref advertisement.

Re: [PATCH 1/2] pack-refs: write peeled entry for non-tags

2013-03-16 Thread Michael Haggerty
Looks good aside from a couple of minor points mentioned below. On 03/16/2013 10:01 AM, Jeff King wrote: When we pack an annotated tag ref, we write not only the sha1 of the tag object along with the ref, but also the sha1 obtained by peeling the tag. This lets readers of the pack-refs file