Re: [PATCH 1/2] remote-helpers: tests: use python directly

2013-05-19 Thread Felipe Contreras
Junio C Hamano wrote: > David Aguilar writes: > > > On Fri, May 17, 2013 at 7:12 PM, Junio C Hamano wrote: > > > >> So it is a right thing to do in that sense. > >> > >> I however am having this nagging feeling that I may be missing > >> something subtle here. Comments from others are very much

Re: [PATCH 1/2] remote-helpers: tests: use python directly

2013-05-18 Thread Junio C Hamano
David Aguilar writes: > On Fri, May 17, 2013 at 7:12 PM, Junio C Hamano wrote: > >> So it is a right thing to do in that sense. >> >> I however am having this nagging feeling that I may be missing >> something subtle here. Comments from others are very much welcome. > > Yes, this is correct. A

Re: [PATCH 1/2] remote-helpers: tests: use python directly

2013-05-17 Thread Felipe Contreras
On Fri, May 17, 2013 at 9:51 PM, David Aguilar wrote: > On Fri, May 17, 2013 at 7:12 PM, Junio C Hamano wrote: >> Felipe Contreras writes: >> >>> These remote helpers use 'env python', not PYTHON_PATH, so that's where >>> we should check for the extensions. Otherwise, if 'python' is not >>> PYTH

Re: [PATCH 1/2] remote-helpers: tests: use python directly

2013-05-17 Thread David Aguilar
On Fri, May 17, 2013 at 7:12 PM, Junio C Hamano wrote: > Felipe Contreras writes: > >> These remote helpers use 'env python', not PYTHON_PATH, so that's where >> we should check for the extensions. Otherwise, if 'python' is not >> PYTHON_PATH (e.g. /usr/bin/python: Makefile's default), there will

Re: [PATCH 1/2] remote-helpers: tests: use python directly

2013-05-17 Thread Junio C Hamano
Felipe Contreras writes: > These remote helpers use 'env python', not PYTHON_PATH, so that's where > we should check for the extensions. Otherwise, if 'python' is not > PYTHON_PATH (e.g. /usr/bin/python: Makefile's default), there will be a > mismatch between the python libraries actually accessi

[PATCH 1/2] remote-helpers: tests: use python directly

2013-05-17 Thread Felipe Contreras
These remote helpers use 'env python', not PYTHON_PATH, so that's where we should check for the extensions. Otherwise, if 'python' is not PYTHON_PATH (e.g. /usr/bin/python: Makefile's default), there will be a mismatch between the python libraries actually accessible to the remote helpers. Suggest