On Wed, May 29, 2013 at 8:54 AM, Duy Nguyen wrote:
> On Wed, May 29, 2013 at 8:46 PM, Felipe Contreras
> wrote:
>> On Wed, May 29, 2013 at 8:42 AM, Duy Nguyen wrote:
>>> On Wed, May 29, 2013 at 8:34 PM, Felipe Contreras
>>> wrote:
On Wed, May 29, 2013 at 8:25 AM, Duy Nguyen wrote:
> O
On Wed, May 29, 2013 at 8:46 PM, Felipe Contreras
wrote:
> On Wed, May 29, 2013 at 8:42 AM, Duy Nguyen wrote:
>> On Wed, May 29, 2013 at 8:34 PM, Felipe Contreras
>> wrote:
>>> On Wed, May 29, 2013 at 8:25 AM, Duy Nguyen wrote:
On Mon, May 27, 2013 at 11:52 PM, Felipe Contreras
wrote
On Wed, May 29, 2013 at 8:42 AM, Duy Nguyen wrote:
> On Wed, May 29, 2013 at 8:34 PM, Felipe Contreras
> wrote:
>> On Wed, May 29, 2013 at 8:25 AM, Duy Nguyen wrote:
>>> On Mon, May 27, 2013 at 11:52 PM, Felipe Contreras
>>> wrote:
We should free objects before leaving.
Signed-of
On Wed, May 29, 2013 at 8:34 PM, Felipe Contreras
wrote:
> On Wed, May 29, 2013 at 8:25 AM, Duy Nguyen wrote:
>> On Mon, May 27, 2013 at 11:52 PM, Felipe Contreras
>> wrote:
>>> We should free objects before leaving.
>>>
>>> Signed-off-by: Felipe Contreras
>>
>> Micronit: perhaps you should mov
On Wed, May 29, 2013 at 8:25 AM, Duy Nguyen wrote:
> On Mon, May 27, 2013 at 11:52 PM, Felipe Contreras
> wrote:
>> We should free objects before leaving.
>>
>> Signed-off-by: Felipe Contreras
>
> Micronit: perhaps you should move the "free obejcts before leaving"
> (in do_pick_commit) to the su
On Mon, May 27, 2013 at 11:52 PM, Felipe Contreras
wrote:
> We should free objects before leaving.
>
> Signed-off-by: Felipe Contreras
Micronit: perhaps you should move the "free obejcts before leaving"
(in do_pick_commit) to the subject instead of "trivial fix", which
adds no value to the patch
On Tue, May 28, 2013 at 09:32:59PM -0500, Felipe Contreras wrote:
> Junio C Hamano wrote:
> > Neil Horman writes:
> >
> > > On Mon, May 27, 2013 at 11:52:18AM -0500, Felipe Contreras wrote:
> > >> We should free objects before leaving.
> > >>
> > >> Signed-off-by: Felipe Contreras
> > >> ---
>
> From: Joachim Schmitz [mailto:j...@schmitz-digital.de]
> Sent: Wednesday, May 29, 2013 1:30 PM
> To: 'Felipe Contreras'
> Cc: 'git@vger.kernel.org'
> Subject: RE: [PATCH 1/2] sequencer: trivial fix
>
> And for the record: I agree with you that these 2 t
> From: Felipe Contreras [mailto:felipe.contre...@gmail.com]
> Sent: Wednesday, May 29, 2013 1:24 PM
> To: Joachim Schmitz
> Cc: git@vger.kernel.org
> Subject: Re: [PATCH 1/2] sequencer: trivial fix
>
> On Wed, May 29, 2013 at 6:13 AM, Joachim Schmitz
> wrote:
>
On Wed, May 29, 2013 at 6:13 AM, Joachim Schmitz
wrote:
>> From: Felipe Contreras [mailto:felipe.contre...@gmail.com]
>> Sent: Wednesday, May 29, 2013 12:52 PM
>> To: Joachim Schmitz
>> Cc: git@vger.kernel.org
>> Subject: Re: [PATCH 1/2] sequencer: trivial fix
>
> From: Felipe Contreras [mailto:felipe.contre...@gmail.com]
> Sent: Wednesday, May 29, 2013 12:52 PM
> To: Joachim Schmitz
> Cc: git@vger.kernel.org
> Subject: Re: [PATCH 1/2] sequencer: trivial fix
>
> On Wed, May 29, 2013 at 4:58 AM, Joachim Schmitz
> wrote:
&g
On Wed, May 29, 2013 at 4:58 AM, Joachim Schmitz
wrote:
> Felipe Contreras wrote:
>>
>> Junio C Hamano wrote:
>>> It probably is better to fold this patch into the other one when it
>>> is rerolled to correct the option name gotcha "on the tin".
>>
>>
>> Why? This patch is standalone and fixes an
Felipe Contreras wrote:
Junio C Hamano wrote:
Neil Horman writes:
On Mon, May 27, 2013 at 11:52:18AM -0500, Felipe Contreras wrote:
We should free objects before leaving.
Signed-off-by: Felipe Contreras
---
sequencer.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --g
Junio C Hamano wrote:
> Neil Horman writes:
>
> > On Mon, May 27, 2013 at 11:52:18AM -0500, Felipe Contreras wrote:
> >> We should free objects before leaving.
> >>
> >> Signed-off-by: Felipe Contreras
> >> ---
> >> sequencer.c | 7 +--
> >> 1 file changed, 5 insertions(+), 2 deletions(-)
Neil Horman writes:
> On Mon, May 27, 2013 at 11:52:18AM -0500, Felipe Contreras wrote:
>> We should free objects before leaving.
>>
>> Signed-off-by: Felipe Contreras
>> ---
>> sequencer.c | 7 +--
>> 1 file changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/sequencer.c b/sequen
On Mon, May 27, 2013 at 11:52:18AM -0500, Felipe Contreras wrote:
> We should free objects before leaving.
>
> Signed-off-by: Felipe Contreras
> ---
> sequencer.c | 7 +--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/sequencer.c b/sequencer.c
> index ab6f8a7..7eeae2f 1
We should free objects before leaving.
Signed-off-by: Felipe Contreras
---
sequencer.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/sequencer.c b/sequencer.c
index ab6f8a7..7eeae2f 100644
--- a/sequencer.c
+++ b/sequencer.c
@@ -626,12 +626,15 @@ static int do_pick_c
17 matches
Mail list logo