[PATCH 1/2] t0003: do not chdir the whole test process

2014-02-06 Thread Junio C Hamano
Moving to some other directory and letting the remainder of the test pieces to expect that they start there is a bad practice. The test that contains chdir itself may fail (or by mistake skipped via the GIT_SKIP_TESTS mechanism) in which case the remainder may operate on files in unexpected

Re: [PATCH 1/2] t0003: do not chdir the whole test process

2014-02-06 Thread Jonathan Nieder
Junio C Hamano wrote: Moving to some other directory and letting the remainder of the test pieces to expect that they start there is a bad practice. I agree with the above, and I like the patch... The test that contains chdir itself

Re: [PATCH 1/2] t0003: do not chdir the whole test process

2014-02-06 Thread Jonathan Nieder
Junio C Hamano wrote: Jonathan Nieder jrnie...@gmail.com writes: The test that contains chdir itself may fail (or by mistake skipped via the GIT_SKIP_TESTS mechanism) in which case the remainder may operate on files in unexpected

Re: [PATCH 1/2] t0003: do not chdir the whole test process

2014-02-06 Thread Junio C Hamano
Jonathan Nieder jrnie...@gmail.com writes: Junio C Hamano wrote: Moving to some other directory and letting the remainder of the test pieces to expect that they start there is a bad practice. I agree with the above, and I like the patch...

Re: [PATCH 1/2] t0003: do not chdir the whole test process

2014-02-06 Thread Junio C Hamano
Jonathan Nieder jrnie...@gmail.com writes: For a while I've been wanting to teach GIT_SKIP_TESTS not to skip tests with 'setup' or 'set up' in their name, but I never got around to it. Yeah, that would be a good thing. As part of doing so, we might want to come up with a way to test the