David Turner dtur...@twopensource.com writes:
This causes my test to pass and generally seems correct to me.
Yes, this approach is very sensible, and I'll queue.
But watchman support _should_ be prepared for a program that does
not do this. Developing your support in on a codebase with this
On Wed, 2014-05-07 at 10:42 -0700, Junio C Hamano wrote:
David Turner dtur...@twopensource.com writes:
This causes my test to pass and generally seems correct to me.
Yes, this approach is very sensible, and I'll queue.
But watchman support _should_ be prepared for a program that does
dtur...@twopensource.com writes:
From: David Turner dtur...@twitter.com
Signed-off-by: David Turner dtur...@twitter.com
Ehh, why?
---
builtin/grep.c | 14 --
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/builtin/grep.c b/builtin/grep.c
index
On Tue, 2014-05-06 at 15:24 -0700, Junio C Hamano wrote:
dtur...@twopensource.com writes:
From: David Turner dtur...@twitter.com
Signed-off-by: David Turner dtur...@twitter.com
Ehh, why?
Briefly, because otherwise ./t7811-grep-open.sh fails when run under
watchman.
This is actually
On Tue, May 06, 2014 at 05:06:51PM -0700, David Turner wrote:
On Tue, 2014-05-06 at 15:24 -0700, Junio C Hamano wrote:
dtur...@twopensource.com writes:
From: David Turner dtur...@twitter.com
Signed-off-by: David Turner dtur...@twitter.com
Ehh, why?
Briefly, because
This causes my test to pass and generally seems correct to me.
On Tue, 2014-05-06 at 23:00 -0400, Jeff King wrote:
...
That being said, this really seems like something that the run-command
interface should be doing, since it can handle the chdir in the forked
child. And indeed, it seems to
From: David Turner dtur...@twitter.com
Signed-off-by: David Turner dtur...@twitter.com
---
builtin/grep.c | 14 --
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/builtin/grep.c b/builtin/grep.c
index 69ac2d8..e9fe040 100644
--- a/builtin/grep.c
+++ b/builtin/grep.c
@@
7 matches
Mail list logo