[PATCH 1/3] push: factor out the detached HEAD error message

2013-05-29 Thread Ramkumar Ramachandra
With push.default set to upstream or simple, and a detached HEAD, git
push prints the following error:

  $ git push
  fatal: You are not currently on a branch.
  To push the history leading to the current (detached HEAD)
  state now, use

git push ram HEAD:

This error is not unique to upstream or simple: current cannot push with
a detached HEAD either.  So, factor out the error string in preparation
for using it in current.

Signed-off-by: Ramkumar Ramachandra 
---
 builtin/push.c | 14 --
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/builtin/push.c b/builtin/push.c
index 909c34d..ef3aa97 100644
--- a/builtin/push.c
+++ b/builtin/push.c
@@ -113,17 +113,19 @@ static NORETURN int die_push_simple(struct branch 
*branch, struct remote *remote
remote->name, branch->name, advice_maybe);
 }
 
+static const char message_detached_head_die[] =
+   N_("You are not currently on a branch.\n"
+  "To push the history leading to the current (detached HEAD)\n"
+  "state now, use\n"
+  "\n"
+  "git push %s HEAD:\n");
+
 static void setup_push_upstream(struct remote *remote, int simple)
 {
struct strbuf refspec = STRBUF_INIT;
struct branch *branch = branch_get(NULL);
if (!branch)
-   die(_("You are not currently on a branch.\n"
-   "To push the history leading to the current (detached 
HEAD)\n"
-   "state now, use\n"
-   "\n"
-   "git push %s HEAD:\n"),
-   remote->name);
+   die(_(message_detached_head_die), remote->name);
if (!branch->merge_nr || !branch->merge || !branch->remote_name)
die(_("The current branch %s has no upstream branch.\n"
"To push the current branch and set the remote as upstream, 
use\n"
-- 
1.8.3.12.gbd56588

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH 1/3] push: factor out the detached HEAD error message

2013-05-21 Thread Ramkumar Ramachandra
With push.default set to upstream or simple, and a detached HEAD, git
push prints the following error:

  $ git push
  fatal: You are not currently on a branch.
  To push the history leading to the current (detached HEAD)
  state now, use

git push ram HEAD:

This error is not unique to upstream or simple: current cannot push with
a detached HEAD either.  So, factor out the error string in preparation
for using it in current.

Signed-off-by: Ramkumar Ramachandra 
---
 builtin/push.c | 14 --
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/builtin/push.c b/builtin/push.c
index 909c34d..ef3aa97 100644
--- a/builtin/push.c
+++ b/builtin/push.c
@@ -113,17 +113,19 @@ static NORETURN int die_push_simple(struct branch 
*branch, struct remote *remote
remote->name, branch->name, advice_maybe);
 }
 
+static const char message_detached_head_die[] =
+   N_("You are not currently on a branch.\n"
+  "To push the history leading to the current (detached HEAD)\n"
+  "state now, use\n"
+  "\n"
+  "git push %s HEAD:\n");
+
 static void setup_push_upstream(struct remote *remote, int simple)
 {
struct strbuf refspec = STRBUF_INIT;
struct branch *branch = branch_get(NULL);
if (!branch)
-   die(_("You are not currently on a branch.\n"
-   "To push the history leading to the current (detached 
HEAD)\n"
-   "state now, use\n"
-   "\n"
-   "git push %s HEAD:\n"),
-   remote->name);
+   die(_(message_detached_head_die), remote->name);
if (!branch->merge_nr || !branch->merge || !branch->remote_name)
die(_("The current branch %s has no upstream branch.\n"
"To push the current branch and set the remote as upstream, 
use\n"
-- 
1.8.3.rc3.7.gc1ff30b

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html