Re: [PATCH 1/3] remote-testsvn: fix unitialized variable

2012-12-15 Thread Florian Achleitner
On Friday 14 December 2012 17:11:44 Jeff King wrote: > [...] > We can fix it by returning "-1" when no note is found (so on > a zero return, we always found a valid value). Good fix. Parsing of the note now always fails if the note doesn't contain the expected string, as it should. > > Signed-

[PATCH 1/3] remote-testsvn: fix unitialized variable

2012-12-14 Thread Jeff King
In remote-test-svn, there is a parse_rev_note function to parse lines of the form "Revision-number" from notes. If it finds such a line and parses it, it returns 0, copying the value into a "struct rev_note". If it finds an entry that is garbled or out of range, it returns -1 to signal an error. H