Re: [PATCH 1/3] t/t5318: introduce failing 'git commit-graph write' tests

2019-09-06 Thread Derrick Stolee
On 9/5/2019 6:04 PM, Taylor Blau wrote: > When invoking 'git commit-graph' in a corrupt repository, one can cause > a segfault when ancestral commits are corrupt in one way or another. > This is due to two function calls in the 'commit-graph.c' code that may > return NULL, but are not checked for N

[PATCH 1/3] t/t5318: introduce failing 'git commit-graph write' tests

2019-09-05 Thread Taylor Blau
When invoking 'git commit-graph' in a corrupt repository, one can cause a segfault when ancestral commits are corrupt in one way or another. This is due to two function calls in the 'commit-graph.c' code that may return NULL, but are not checked for NULL-ness before dereferencing. Before fixing th