Re: [PATCH 1/4] t/t7502: compare entire commit message with what was expected

2013-02-19 Thread Junio C Hamano
Jonathan Nieder writes: > The downside (not a new problem, but a downside nonetheless) is that > it means the test doesn't demonstrate what --cleanup=verbatim --status > will do. > > How about something like this? Can't we be a bit more robust by not using a hardcoded block of lines as the "expe

Re: [PATCH 1/4] t/t7502: compare entire commit message with what was expected

2013-02-18 Thread Jonathan Nieder
Jonathan Nieder wrote: > +++ w/t/t7502-commit.sh [...] > + # Please enter the commit message for your changes. Lines > starting > + # with '\''#'\'' will be kept; you may remove them yourself if > you want to. > + # An empty message aborts the commit. > +

Re: [PATCH 1/4] t/t7502: compare entire commit message with what was expected

2013-02-18 Thread Jonathan Nieder
Brandon Casey wrote: > So, let's use the --no-status option to 'git commit' which will cause > git to refrain from appending the lines of instructional text to the > commit message. This will allow the entire resulting commit message to > be compared against the expected value. The downside (not

[PATCH 1/4] t/t7502: compare entire commit message with what was expected

2013-02-18 Thread Brandon Casey
This test attempts to verify that a commit in "verbatim" mode, when supplied a commit template, produces a commit in which the commit message matches exactly the template that was supplied. But, since the commit operation appends additional instructions for the user as comments in the commit buffe