Jeff King p...@peff.net writes:
On Sun, Feb 16, 2014 at 05:22:45PM +0100, David Kastrup wrote:
config.c:#undef config_error_nonbool
config.c:int config_error_nonbool(const char *var)
You could always look in the commit history:
$ git log -S'#define config_error_nonbool' cache.h
or
On Tue, Feb 18, 2014 at 09:41:51AM +0100, David Kastrup wrote:
gcc's flow analysis works with the same data as humans reading the
code. If there is no information content in the function call, it makes
more sense to either making it void.
The point of error() returning a constant -1 is to
Jeff King p...@peff.net writes:
On Tue, Feb 18, 2014 at 09:41:51AM +0100, David Kastrup wrote:
gcc's flow analysis works with the same data as humans reading the
code. If there is no information content in the function call, it makes
more sense to either making it void.
The point of
On Sun, Feb 16, 2014 at 05:22:45PM +0100, David Kastrup wrote:
Not really relevant to this patch, but looking at the output of
git grep config_error_nonbool
seems like a serious amount of ridiculousness going on. The header
shows
cache.h:extern int config_error_nonbool(const char *);
If we carry on after outputting config_error_nonbool then we're
guaranteed to dereference a null pointer.
Signed-off-by: John Keeping j...@keeping.me.uk
---
notes-utils.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/notes-utils.c b/notes-utils.c
index 2975dcd..4aa7023
John Keeping j...@keeping.me.uk writes:
If we carry on after outputting config_error_nonbool then we're
guaranteed to dereference a null pointer.
Not really relevant to this patch, but looking at the output of
git grep config_error_nonbool
seems like a serious amount of ridiculousness going
6 matches
Mail list logo
