Re: [PATCH 1/6] ident: make user_ident_explicitly_given private

2012-11-14 Thread Jonathan Nieder
Jeff King wrote: There are no users of this global variable, as queriers go through the user_ident_sufficiently_given accessor. Let's make it private, which will enable further refactoring. [...] --- a/cache.h +++ b/cache.h @@ -1149,10 +1149,6 @@ struct config_include_data { #define

Re: [PATCH 1/6] ident: make user_ident_explicitly_given private

2012-11-14 Thread Jeff King
On Wed, Nov 14, 2012 at 08:44:57AM -0800, Jonathan Nieder wrote: -#define IDENT_NAME_GIVEN 01 -#define IDENT_MAIL_GIVEN 02 -#define IDENT_ALL_GIVEN (IDENT_NAME_GIVEN|IDENT_MAIL_GIVEN) -extern int user_ident_explicitly_given; extern int user_ident_sufficiently_given(void); In

[PATCH 1/6] ident: make user_ident_explicitly_given private

2012-11-13 Thread Jeff King
There are no users of this global variable, as queriers go through the user_ident_sufficiently_given accessor. Let's make it private, which will enable further refactoring. Signed-off-by: Jeff King p...@peff.net --- cache.h | 4 ident.c | 6 +- 2 files changed, 5 insertions(+), 5