Re: [PATCH 1/6] pull: drop confusing prefix parameter of die_on_unclean_work_tree()

Johannes Schindelin writes: > -static int has_unstaged_changes(const char *prefix) > +static int has_unstaged_changes(void) > { > struct rev_info rev_info; > int result; > > - init_revisions(_info, prefix); > + init_revisions(_info, NULL); >

[PATCH 1/6] pull: drop confusing prefix parameter of die_on_unclean_work_tree()

In cmd_pull(), when verifying that there are no changes preventing a rebasing pull, we diligently pass the prefix parameter to the die_on_unclean_work_tree() function which in turn diligently passes it to the has_unstaged_changes() and has_uncommitted_changes() functions. The casual reader might