Re: [PATCH 1/8] gpg-interface: handle bool user.signingkey

On Mon, Apr 09, 2018 at 04:55:26PM -0400, Eric Sunshine wrote: > Peff's Signed-off-by: is missing. Also, since you're forwarding this > patch on Peff's behalf, your Signed-off-by: should follow his. Same > comment applies to all patches by Peff in this series. I usually sign-off as I send to the

Re: [PATCH 1/8] gpg-interface: handle bool user.signingkey

On Mon, Apr 9, 2018 at 4:41 PM, Ben Toews wrote: > From: Jeff King > > The config handler for user.signingkey does not check for a > boolean value, and thus: > > git -c user.signingkey tag > > will segfault. We could fix this and even shorten the code > by

[PATCH 1/8] gpg-interface: handle bool user.signingkey

From: Jeff King The config handler for user.signingkey does not check for a boolean value, and thus: git -c user.signingkey tag will segfault. We could fix this and even shorten the code by using git_config_string(). But our set_signing_key() helper is used by other code