Re: [PATCH 1/8] perl: *.pm files should not have the executable bit
On Wed, Feb 14 2018, Jonathan Nieder jotted:
> Hi,
>
> Ævar Arnfjörð Bjarmason wrote:
>
>> The Git::Mail::Address file added in bd869f67b9 ("send-email: add and
>> use a local copy of Mail::Address", 2018-01-05) had the executable bit
>> set, this should not be the case with *.pm files, it breaks nothing,
>> but is redundant and confusing as none of the other files have it, and
>> it's never executed as a stand-alone program.
>
> Needs a period somewhere to break up the long sentence with comma
> splices. How about:
>
> The Git::Mail::Address file added in bd869f67b9 ("send-email: add and
> use a local copy of Mail::Address", 2018-01-05) had the executable bit
> set. That bit should not be set for *.pm files. It breaks nothing but
> but it is redundant and confusing as none of the other files have it
> and these files are never executed as stand-alone programs.
Thanks, used this with s/but but/but/
>> Signed-off-by: Ævar Arnfjörð Bjarmason
>
> With or without such a tweak,
> Reviewed-by: Jonathan Nieder
>
> Thanks.
Re: [PATCH 1/8] perl: *.pm files should not have the executable bit
Hi,
Ævar Arnfjörð Bjarmason wrote:
> The Git::Mail::Address file added in bd869f67b9 ("send-email: add and
> use a local copy of Mail::Address", 2018-01-05) had the executable bit
> set, this should not be the case with *.pm files, it breaks nothing,
> but is redundant and confusing as none of the other files have it, and
> it's never executed as a stand-alone program.
Needs a period somewhere to break up the long sentence with comma
splices. How about:
The Git::Mail::Address file added in bd869f67b9 ("send-email: add and
use a local copy of Mail::Address", 2018-01-05) had the executable bit
set. That bit should not be set for *.pm files. It breaks nothing but
but it is redundant and confusing as none of the other files have it
and these files are never executed as stand-alone programs.
> Signed-off-by: Ævar Arnfjörð Bjarmason
With or without such a tweak,
Reviewed-by: Jonathan Nieder
Thanks.
[PATCH 1/8] perl: *.pm files should not have the executable bit
The Git::Mail::Address file added in bd869f67b9 ("send-email: add and
use a local copy of Mail::Address", 2018-01-05) had the executable bit
set, this should not be the case with *.pm files, it breaks nothing,
but is redundant and confusing as none of the other files have it, and
it's never executed as a stand-alone program.
Signed-off-by: Ævar Arnfjörð Bjarmason
---
perl/Git/Mail/Address.pm | 0
1 file changed, 0 insertions(+), 0 deletions(-)
mode change 100755 => 100644 perl/Git/Mail/Address.pm
diff --git a/perl/Git/Mail/Address.pm b/perl/Git/Mail/Address.pm
old mode 100755
new mode 100644
--
2.15.1.424.g9478a66081
