Re: [PATCH 1/8] t1300: style updates

2012-10-23 Thread Jeff King
On Wed, Oct 24, 2012 at 08:33:15AM +0200, Johannes Sixt wrote: > Am 10/24/2012 0:35, schrieb Jeff King: > > -test_expect_success 'non-match value' \ > > - 'test wow = $(git config --get nextsection.nonewline !for)' > > +test_expect_success 'non-match value' ' > > + test wow = $(git config --ge

Re: [PATCH 1/8] t1300: style updates

2012-10-23 Thread Johannes Sixt
Am 10/24/2012 0:35, schrieb Jeff King: > -test_expect_success 'non-match value' \ > - 'test wow = $(git config --get nextsection.nonewline !for)' > +test_expect_success 'non-match value' ' > + test wow = $(git config --get nextsection.nonewline !for) > +' Here's a case you forgot to update

[PATCH 1/8] t1300: style updates

2012-10-23 Thread Jeff King
The t1300 test script is quite old, and does not use our modern techniques or styles. This patch updates it in the following ways: 1. Use test_cmp instead of cmp (to make failures easier to debug). 2. Use test_cmp instead of 'test $(command) = expected'. This makes failures much eas