Re: [PATCH 2/2] Makefile: run coccicheck on more source files

2019-09-10 Thread Denton Liu
On Tue, Sep 10, 2019 at 03:28:13PM +0200, SZEDER Gábor wrote: > On Tue, Sep 10, 2019 at 12:44:31AM -0700, Denton Liu wrote: > > Before, when running the "coccicheck" target, only the source files > > which were being compiled would have been checked by Coccinelle. > > However, just because we aren'

Re: [PATCH 2/2] Makefile: run coccicheck on more source files

2019-09-10 Thread SZEDER Gábor
On Tue, Sep 10, 2019 at 12:44:31AM -0700, Denton Liu wrote: > Make the "coccicheck" target run on all C sources except for those that > are taken from some upstream. We don't want to patch these files since > we want them to be as close to upstream as possible so that it'll be > easier to pull in u

Re: [PATCH 2/2] Makefile: run coccicheck on more source files

2019-09-10 Thread SZEDER Gábor
On Tue, Sep 10, 2019 at 12:44:31AM -0700, Denton Liu wrote: > Before, when running the "coccicheck" target, only the source files > which were being compiled would have been checked by Coccinelle. > However, just because we aren't compiling a source file doesn't mean we > have to exclude it from an

[PATCH 2/2] Makefile: run coccicheck on more source files

2019-09-10 Thread Denton Liu
Before, when running the "coccicheck" target, only the source files which were being compiled would have been checked by Coccinelle. However, just because we aren't compiling a source file doesn't mean we have to exclude it from analysis. This will allow us to catch more mistakes, in particular one