Re: [PATCH 2/2] bisect: avoid signed integer overflow

2013-04-03 Thread John Keeping
Signed-off-by: John Keeping j...@keeping.me.uk --- Changes since v1: - Change the function signature instead of casting a value in the function. - This lets us remove an existing cast. bisect.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bisect.c b/bisect.c index

[PATCH 2/2] bisect: avoid signed integer overflow

2013-04-02 Thread John Keeping
Signed-off-by: John Keeping j...@keeping.me.uk --- bisect.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bisect.c b/bisect.c index bd1b7b5..0d33c6f 100644 --- a/bisect.c +++ b/bisect.c @@ -526,7 +526,7 @@ struct commit_list *filter_skipped(struct commit_list *list, * for

Re: [PATCH 2/2] bisect: avoid signed integer overflow

2013-04-02 Thread Junio C Hamano
John Keeping j...@keeping.me.uk writes: Signed-off-by: John Keeping j...@keeping.me.uk --- bisect.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bisect.c b/bisect.c index bd1b7b5..0d33c6f 100644 --- a/bisect.c +++ b/bisect.c @@ -526,7 +526,7 @@ struct commit_list